Skip to content

Commit

Permalink
test: change skip method to skip only on iOS.
Browse files Browse the repository at this point in the history
  • Loading branch information
asafkorem committed Jan 6, 2025
1 parent 30b0dac commit 0b9b92f
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion detox/test/e2e/17.datePicker.test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const jestExpect = require('expect').default;

describe.skipIfNewArch('DatePicker', () => {
describe.skipIfNewArchOnIOS('DatePicker', () => {
describe.each([
['ios', 'compact', 0],
['ios', 'inline', 1],
Expand Down
2 changes: 1 addition & 1 deletion detox/test/e2e/17.picker.test.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
describe.skipIfNewArch(":ios: Picker", () => {
describe.skipIfNewArchOnIOS(":ios: Picker", () => {
beforeEach(async () => {
await device.reloadReactNative();
await element(by.text("Picker")).tap();
Expand Down
2 changes: 1 addition & 1 deletion detox/test/e2e/copilot/09.copilot.datepicker.test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const { default: jestExpect } = require('expect');

describe.skipIfNewArch('DatePicker', () => {
describe.skipIfNewArchOnIOS('DatePicker', () => {
describe.forCopilot('Copilot', () => {
beforeEach(async () => {
await copilot.perform(
Expand Down
4 changes: 2 additions & 2 deletions detox/test/e2e/utils/custom-describes.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ describe.skipIfCI = (title, fn) => {
return isCI ? describe.skip(title, fn) : describe(title, fn);
};

describe.skipIfNewArch = (title, fn) => {
describe.skipIfNewArchOnIOS = (title, fn) => {
const isNewArch = process.env.RCT_NEW_ARCH_ENABLED === '1';
if (isNewArch) {
if (isNewArch && device.getPlatform() === 'ios') {
console.warn('Skipping tests for new architecture, as there are issues related to the new architecture.');
return describe.skip(title, fn);
}
Expand Down

0 comments on commit 0b9b92f

Please sign in to comment.