hotfix: remove SIGINT, SIGTERM handling due to #881 (#883)

wix · Aug 13, 2018 · dd95ad2 · dd95ad2
1 parent 6d4698e
commit dd95ad2
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 29 deletions.
diff --git a/detox/src/Detox.js b/detox/src/Detox.js
@@ -91,11 +91,6 @@ class Detox {
     }
   }
 
-  async terminate() {
-    await this.artifactsManager.onTerminate();
-    await this.cleanup();
-  }
-
   async beforeEach(testSummary) {
     this._validateTestSummary(testSummary);
     this._logTestRunCheckpoint('DETOX_BEFORE_EACH', testSummary);

diff --git a/detox/src/Detox.test.js b/detox/src/Detox.test.js
@@ -243,15 +243,5 @@ describe('Detox', () => {
       await detox.cleanup();
       expect(detox.artifactsManager.onAfterAll).toHaveBeenCalledTimes(1);
     });
-
-    it(`Calling .terminate() will trigger artifacts manager .onTerminate()`, async () => {
-      Detox = require('./Detox');
-
-      detox = new Detox({deviceConfig: validDeviceConfig});
-      detox.artifactsManager.onTerminate = jest.fn();
-
-      await detox.terminate();
-      expect(detox.artifactsManager.onTerminate).toHaveBeenCalledTimes(1);
-    });
   });
 });
diff --git a/detox/src/index.js b/detox/src/index.js
@@ -5,7 +5,6 @@ const platform = require('./platform');
 const exportWrapper = require('./exportWrapper');
 const argparse = require('./utils/argparse');
 const log = require('./utils/logger').child({ __filename });
-const onTerminate = require('./utils/onTerminate');
 const configuration = require('./configuration');
 
 let detox;
@@ -85,9 +84,6 @@ async function cleanup() {
     }
 }
 
-/* istanbul ignore next */
-onTerminate(() => detox && detox.terminate());
-
 module.exports = Object.assign({
   init,
   cleanup,

diff --git a/detox/src/index.test.js b/detox/src/index.test.js
@@ -14,7 +14,6 @@ describe('index', () => {
     jest
       .mock('./server/DetoxServer')
       .mock('./devices/Device')
-      .mock('./utils/onTerminate')
       .mock('./utils/logger')
       .mock('./client/Client')
       .mock('./Detox', () => jest.fn(() => mockDetox))
@@ -29,7 +28,6 @@ describe('index', () => {
     jest
       .unmock('./server/DetoxServer')
       .unmock('./devices/Device')
-      .unmock('./utils/onTerminate')
       .unmock('./client/Client')
       .unmock('./Detox')
       .unmock('./platform');

diff --git a/detox/src/utils/onTerminate.js b/detox/src/utils/onTerminate.js