Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass in files to the cli like jest and mocha do by default #1132

Closed
tjbenton opened this issue Jan 25, 2019 · 3 comments
Closed

pass in files to the cli like jest and mocha do by default #1132

tjbenton opened this issue Jan 25, 2019 · 3 comments

Comments

@tjbenton
Copy link

Currently to specify a specific file you have to do this

detox test --file 'some/file.js'

to test a folder you have to do this

detox test --specs 'some/folder'

and there's a PR open to allow for regex #1083 which you will be able to do like this

detox test --file 'some/**/*.js'
detox test --specs 'some/**/*.js'

Both Mocha and Jest have their setups to already support this by simply passing in all extra files at the end of the commands without having to specify --file or --specs.

jest 'something/**/*.js'
mocha 'something/**/*.js'

Detox can simplify it's arguments and make it more consistent with both of these testing libraries by following their pattern since commander already supports this simple feature.

This is pretty easy to implement all you would have to do is change this line to be

.command('test [testPattern...]]', 'Initiating your test suite')

and then deprecate the --file and --specs so that it shows they're deprecated but will still work.

@stale
Copy link

stale bot commented Feb 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back.
Thank you for your contributions.

@stale stale bot added the 🏚 stale label Feb 24, 2019
@stale
Copy link

stale bot commented Mar 3, 2019

The issue has been closed for inactivity.

@stale stale bot closed this as completed Mar 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 6, 2019
@noomorph noomorph reopened this Mar 26, 2019
@stale stale bot removed the 🏚 stale label Mar 26, 2019
@noomorph
Copy link
Collaborator

Wil be resolved by #1109

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants