Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Regular Expressions in Jest Runner #1083

Merged

Conversation

a-dilettante
Copy link
Contributor


Description:

Jest allows you to provide a regex pattern in order to run tests. Unfortunately I am unable to get the tests to run when the regex pattern is passed to Jest.

In the Jest documentation it's mentioned that:

Depending on your terminal, you may need to quote this argument: jest "my.*(complex)?pattern"

The proposed solution wraps the file argument in quotation marks to in order to support regex patterns along side specifying a file path.

@a-dilettante
Copy link
Contributor Author

Hi @DanielMSchmidt, is there any movement on this?

Thanks

@DanielMSchmidt
Copy link
Contributor

Sorry, had a lot to do the other day, I'm going to check this right now 💪

@DanielMSchmidt
Copy link
Contributor

Thank you for your help. The PR seems fine, what do you think @rotemmiz?

@rotemmiz
Copy link
Member

How will it integrate with your refactor @DanielMSchmidt ?

  • Why not just add the quotes inside the command itself?

@DanielMSchmidt
Copy link
Contributor

@rotemmiz I will add it there if we merge this branch

@rotemmiz rotemmiz merged commit eebf6b9 into wix:master Jan 25, 2019
@tjbenton tjbenton mentioned this pull request Jan 25, 2019
2 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants