Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export globals #275

Closed
trofima opened this issue Sep 13, 2017 · 4 comments
Closed

export globals #275

trofima opened this issue Sep 13, 2017 · 4 comments
Labels
type: enhancement ⚡️

Comments

@trofima
Copy link
Contributor

trofima commented Sep 13, 2017

Description

Please export detox objects for to be able to import them (i.e. element, by etc.).
This is needed to properly use detox in test flow libraries based on it.
@LeoNatan
Copy link
Contributor

PRs are welcome.

@coderjonny coderjonny mentioned this issue Feb 6, 2018
Merged
@coderjonny
Copy link

@trofima great job with exposing the globals!

I've created a flowTyped library definition for them.
flow-typed/flow-typed#1824

Cheers

@coderjonny
Copy link

Should we close this issue btw?

@rotemmiz
Copy link
Member

rotemmiz commented Feb 6, 2018

Indeed
Closed by #374

@rotemmiz rotemmiz closed this as completed Feb 6, 2018
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: enhancement ⚡️
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@coderjonny @rotemmiz @trofima @LeoNatan