You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the app does not get launched inside detox.init(...) call, then beforeAll hook in log plugins (ADBLogcatPlugin is affected and SimulatorLogPlugin might be too) has no actual opportunity to read app logs. This is completely reasonable since there is no app running to start with.
Users are getting exceptions like this:
Caught exception inside plugin (ADBLogcatPlugin) at phase onBeforeEach
DetoxRuntimeError: DetoxRuntimeError: Detox Artifacts API had no app pid at the time of calling
at Object.getPid (/Users/kevinlalka/Projects/dev/project-react-native-porting/node_modules/detox/src/artifacts/Art
ifactsManager.js:58:17)
at ADBLogcatPlugin.createTestRecording (/Users/kevinlalka/Projects/dev/project-react-native-porting/node_modules/d
etox/src/artifacts/log/android/ADBLogcatPlugin.js:25:26)
at ADBLogcatPlugin.createTestArtifact (/Users/kevinlalka/Projects/dev/project-react-native-porting/node_modules/de
tox/src/artifacts/templates/plugin/WholeTestRecorderPlugin.js:42:17)
at ADBLogcatPlugin.onBeforeEach (/Users/kevinlalka/Projects/dev/project-react-native-porting/node_modules/detox/sr
c/artifacts/templates/plugin/WholeTestRecorderPlugin.js:17:30)
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:188:7)
This needs to be addressed by rewriting logic of abstract base class StartupAndTestRecordingPlugin and the implementations of SimulatorLogPlugin and ADBLogcatPlugin accordingly. They should mostly rely on onLaunchApp hook rather than onBeforeAll.
The text was updated successfully, but these errors were encountered:
When the app does not get launched inside
detox.init(...)
call, thenbeforeAll
hook in log plugins (ADBLogcatPlugin
is affected andSimulatorLogPlugin
might be too) has no actual opportunity to read app logs. This is completely reasonable since there is no app running to start with.Users are getting exceptions like this:
This needs to be addressed by rewriting logic of abstract base class
StartupAndTestRecordingPlugin
and the implementations ofSimulatorLogPlugin
andADBLogcatPlugin
accordingly. They should mostly rely ononLaunchApp
hook rather thanonBeforeAll
.The text was updated successfully, but these errors were encountered: