Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List possible values for type #1003

Merged
merged 2 commits into from
Nov 10, 2018
Merged

List possible values for type #1003

merged 2 commits into from
Nov 10, 2018

Conversation

solkaz
Copy link
Contributor

@solkaz solkaz commented Oct 29, 2018

Lists the possible values for the type configuration, even though ios.simulator is the only supported value.

@solkaz solkaz requested a review from rotemmiz as a code owner October 29, 2018 14:57
Copy link
Member

@rotemmiz rotemmiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Please read the comments.

|`name`|device name, aligns to the device list avaliable through `xcrun simctl list` for example, this is one line of the output of `xcrun simctl list`: `A3C93900-6D17-4830-8FBE-E102E4BBCBB9 iPhone 7 Shutdown iPhone 7 iOS 10.2`, ir order to choose the first `iPhone 7` regardless of OS version, use `iPhone 7`. <br>To be OS specific use `iPhone 7, iOS 10.2`|
|`build`| **[optional]** build command (either `xcodebuild`, `react-native run-ios`, etc...), will be later available through detox CLI tool.|
|`binaryPath`| Relative path to the ipa/app due to be tested (make sure you build the app in a project relative path)|
|`type`| Device type, available options are `ios.simulator`, `ios.none`, `android.emulator`, and `android.attached`. Currently only `ios.simulator` is supported. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently onlyios.simulator is supported. can be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do, but to be sure, the other options are supported now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the other options are supported as well.

Other values for `type` are supported
@LeoNatan
Copy link
Contributor

Thank you for your contribution!

@LeoNatan LeoNatan merged commit 0944c5a into wix:master Nov 10, 2018
@rotemmiz
Copy link
Member

Currently only ios.simulator is supported. should still be removed

@LeoNatan
Copy link
Contributor

LeoNatan commented Nov 10, 2018

It was removed in the last commit, or are you seeing another one? @rotemmiz

cb87fb4#diff-bb1665a7a4488b29922da9a1a0591a6dR14

@rotemmiz
Copy link
Member

Yes, I didn't catch that

@solkaz solkaz deleted the patch-1 branch November 11, 2018 03:28
@lock lock bot locked as resolved and limited conversation to collaborators Nov 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants