Select date on IOS UIDatePicker with actionForSetDate #1148
Conversation
|
Thanks for submitting this PR. Will review shortly. |
detox/ios/Detox/GREYActions+Detox.h
Outdated
|
|
||
| @interface GREYActions (Detox) | ||
|
|
||
| + (id<GREYAction>)detoxSetDatePickerDateIOSOnly:(NSString *)dateString withFormat:(NSString *)dateFormat; |
There was a problem hiding this comment.
Let's not call this "IOSOnly". Should be detoxSetDatePickerDate:withFormat:.
detox/ios/Detox/GREYActions+Detox.m
Outdated
|
|
||
| @implementation GREYActions (Detox) | ||
|
|
||
| + (id<GREYAction>)detoxSetDatePickerDateIOSOnly:(NSString *)dateString withFormat:(NSString *)dateFormat |
There was a problem hiding this comment.
Likewise, detoxSetDatePickerDate:withFormat:.
detox/test/e2e/17.datePicker.test.js
Outdated
| }); | ||
|
|
||
| it('can select dates on a UIDatePicker', async () => { | ||
| await element(by.type('UIDatePicker')).setDatePickerDateIOSOnly('2019-02-06T05:10:00-08:00', "yyyy-MM-dd'T'HH:mm:ssZZZZZ"); |
There was a problem hiding this comment.
This should be setDatePickerDate and documentation should be updated to state it is for iOS only, as are the current picker view APIs.
There was a problem hiding this comment.
Also, please add documentation on the new action here: https://github.com/wix/Detox/blob/master/docs/APIRef.ActionsOnElement.md
|
@LeoNatan https://jenkins-oss.wixpress.com/job/multi-detox-pr/920/ - Failure seems unrelated to any of the recent changes. 🤷♂️ |
|
Looks good. CI is flaky. |
|
@rotemmiz Let's merge? |
|
Android e2e hangs, wonder why |
| StyleSheet, | ||
| DatePickerIOS | ||
| } from 'react-native'; | ||
| import { Text, View, StyleSheet, DatePickerIOS } from 'react-native'; |
There was a problem hiding this comment.
You can't add DatePickerIOS on a shared component, it needs to run on both iOS and Android.
You might need to split this screen to .ios.js and .android.js.
This is probably the reason why the e2e hangs, the app crashes.
There was a problem hiding this comment.
But that’s not a new change. How did it work until now?
There was a problem hiding this comment.
ho, you're right, I haven't noticed that
|
Please see my comment, I think I found the reason for Android E2E's hangs |
Description:
Addresses the following issues:
#778
#1051
The problem:
Using
setColumnToValueto select the correct date on a DatePickerIOS does not work as expected. This issue defines a solution to select a valid value from the0column by using the value of the label. The solution breaks down because the date picker contains the same label for every year in the list. Attempting to selectFeb 8for 2019 would result in selectingFeb 8for 2006, which is the minimum date in the list.Example usage of setColumnToValue on DatePickerIOS:
react-native DatePickerIOS renders the date in the UIDatePicker as 2 labels. The first being the 3 letter month abbreviation and day, the second being the 3 letter day abbreviation. Using
setColumnToValuebreaks down when trying to select the correct date since the implementation of Earl Grey'sGREYPickerActionselects only the first label see here. Even if Earl Grey were able to compare using all the labels with a list item, a UIDatePicker would be limited to only 7 years worth of dates. This would not be maintainable since we are not in control of the default range for UIDatePicker, nor is it acceptable to force users to limit the list in their application.Solution:
Expose an existing Earl Grey action called actionForSetDate within Detox.