Detox Instruments Integration (Phase 1) #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@noomorph Could you please take the "Artifacts manager should collect the recordings" and "Change Detox server to notify testee in case tester is disconnected" tasks? Thanks |
|
For now, every test has its own recording file. I first sanitize the fullName string for file name ( |
event structure:
```
{
"title": "should have welcome screen", //test name
"fullName": "Sanity should have welcome screen", //suite + test name
"status": "passed" // running/passed/failed
}
```
If the user has already loaded the Profiler framework, use that If not, attempt loading from default path
Handle test summaries in native
Stop recording when tests end
…hardcoded profiler path from /Applications Delay loading to a fraction later to allow logging facility to load.
noomorph
force-pushed
the
DetoxInstrumentsIntegration
branch
from
560bb51 to
095a652
Compare
This reverts commit c63b929.
LeoNatan
commented
Apr 3, 2019
noomorph
approved these changes
Apr 11, 2019
noomorph
approved these changes
Apr 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add initial integration between Detox and Detox Instruments.
Detox will load or use the already loaded Profiler framework and call its APIs to record performance metrics for each test. Each recording will be collected by the artifacts manager.
Discussion/Tasks
xcrun simctl terminate.