-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Device Orientation Manipulation #133
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4f9d94d
add orientation change screen to test app
DanielMSchmidt 1cfc199
add orientation change e2e test
DanielMSchmidt e37a429
add UIDeviceOrientation type for method invocation
DanielMSchmidt 78111e4
add setOrientation to device
DanielMSchmidt 7bc9b52
refactor earl grey call and orientation constants
DanielMSchmidt d0c6f3b
move setOrientation implementation to simulator
DanielMSchmidt 41b24d9
add unit tests for orientation change
DanielMSchmidt 582103f
refactor call to EarlGrey
DanielMSchmidt 8590f44
document new api surface for orientation change
DanielMSchmidt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import React, { Component } from 'react'; | ||
import { | ||
Text, | ||
View, | ||
TouchableOpacity | ||
} from 'react-native'; | ||
|
||
export default class Orientation extends Component { | ||
|
||
constructor(props) { | ||
super(props); | ||
this.state = { | ||
horizontal: false | ||
}; | ||
console.log('Orientation react component constructed (console.log test)'); | ||
} | ||
|
||
detectHorizontal({nativeEvent: {layout: {width, height,x,y}}}) { | ||
this.setState({ | ||
horizontal: width > height | ||
}); | ||
} | ||
|
||
render() { | ||
return ( | ||
<View onLayout={this.detectHorizontal.bind(this)} style={{flex: 1, paddingTop: 20, justifyContent: 'flex-start', alignItems: 'center'}}> | ||
<Text testID="currentOrientation" style={{fontSize: 25, marginTop: 50}}> | ||
{this.state.horizontal ? 'Landscape' : 'Portrait'} | ||
</Text> | ||
</View> | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome stuff!