Introduce restricted support in RN .58+ for Android #1416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoNatan
reviewed
May 30, 2019
| await expect(element(by.id('deletedFromHierarchyText'))).toBeVisible(); | ||
| await element(by.id('GoButton')).tap(); | ||
| await waitFor(element(by.id('deletedFromHierarchyText'))).toBeNotVisible().withTimeout(20000); | ||
| await expect(element(by.id('deletedFromHierarchyText'))).toBeNotVisible(); | ||
| }); | ||
|
|
||
| it('should find element by scrolling until it is visible', async() => { | ||
| custom.it.withFailureIf.android.rn58OrNewer('should find element by scrolling until it is visible', async () => { |
There was a problem hiding this comment.
What is the point of this if we know it will fail anyway? We will be running the RN59 suite from now on, on both iOS and Android. Why not just close it off for Android until we have a proper fix?
There was a problem hiding this comment.
This is so we'd know when (if) they decide to get it fixed.
d4vidi
force-pushed
the
rn59
branch
2 times, most recently
from
6e73cbb
to
84a6f64
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Introduce required changes in order to have our demo app test suite successfully run on Android (with the necessary restrictions introduced by the RN issue).