device: add `resetContentAndSettings` #217

formatlos · 2017-07-31T09:03:30Z

I added a new method to device to cleanup the device (like "Simulator > Reset Content and Settings" menu-item does), because I want to test specific screens which are only shown when the permissions are not set yet (e.g. a screen for explaining why the specific permission is needed)

LeoNatan · 2017-07-31T11:47:58Z

detox/src/devices/Fbsimctl.js

@@ -173,6 +173,14 @@ class Fbsimctl {
    await this._execFbsimctlCommand(options);
  }

+  async resetContentAndSettings(udid) {


I think this is better suited as an input param to device.launchApp(), inline with other API we have.

CC @rotemmiz

how would you name that param? clean?

Not sure it fits launchApp since it has no relation to the app, it's more of a device function (like setLocation or setOrientation)

clean can be confusing, since a user might think this option cleans the app, not resets the entire simulator.

so is it alright then or do you want me to change something?

@LeoNatan just wanted to know if there are still concerns about the PR?

I don't think so. Need @rotemmiz to approve it, as he is the JS master around here. 😄

Never wished for this title :( ...
Let's talk a bit about the API:

I don't this is not a good API for reseting a permission, I much prefer if we can add an unset state to permissions with appleSimUtils Unsetting an already set permission AppleSimulatorUtils#8

Can there still can be a valid test case for resetting a device?

Since we aim Detox to be multi-platform framework I prefer not to give this method a name which is strongly recognized with Apple's terms, let's try thinking of something more generic maybe, like reset or clearData (not sure if these are better names). WDYT ?

rotemmiz · 2017-08-13T20:57:03Z

detox/test/e2e/f-device.js

@@ -1,4 +1,4 @@
-describe('Device', () => {
+describe.only('Device', () => {


don't forget to remove the only

oops, good point

rotemmiz · 2017-08-13T21:01:42Z

detox/src/devices/Fbsimctl.js

@@ -173,6 +173,14 @@ class Fbsimctl {
    await this._execFbsimctlCommand(options);
  }

+  async resetContentAndSettings(udid) {


Never wished for this title :( ...
Let's talk a bit about the API:

I don't this is not a good API for reseting a permission, I much prefer if we can add an unset state to permissions with appleSimUtils Unsetting an already set permission AppleSimulatorUtils#8

Can there still can be a valid test case for resetting a device?

Since we aim Detox to be multi-platform framework I prefer not to give this method a name which is strongly recognized with Apple's terms, let's try thinking of something more generic maybe, like reset or clearData (not sure if these are better names). WDYT ?

formatlos · 2017-08-14T06:38:36Z

Well that's why I didn't call it unsetPermission whatever ... So it's not just about resetting the permissions, that was just one example. Even more important for me is to be sure to start with a clean state of the simulator. Once in a while my detox tests start to fail, because the simulator seems to be in a "dirty" state (after resetContentAndSettings everything runs as expected again).
Another thing would be to clean up the bundle Documents folder, local DBs, etc.
good question
In general I also don't like the name being tied to one specific Platform. I also thought about reset or something along the lines in the first place, but in the end decided against it for one specific reason: It's not just resetting this one app and not just cleaning the data, it's resetting the whole simulator to a clean state.
Also there might not even be a similar thing in android, so I thought it's better to stick with the ios term and not try to introduce new nomenclature for something that doesn't exist platform independent anyway.
And also: if there is the functionality for android to reset all content and settings of the device the name resetContentAndSettings would be more than appropriate also for android, right?
Apart from this concerns I'm also fine with renaming it...

device: add resetContentAndSettings

15da7a4

LeoNatan suggested changes Jul 31, 2017

View reviewed changes

rotemmiz reviewed Aug 13, 2017

View reviewed changes

remove only from e2e test

f3100c6

rotemmiz merged commit 4814bac into wix:master Aug 15, 2017

wix locked and limited conversation to collaborators Jul 23, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

device: add `resetContentAndSettings` #217

device: add `resetContentAndSettings` #217

formatlos commented Jul 31, 2017

LeoNatan Jul 31, 2017

LeoNatan Jul 31, 2017

formatlos Jul 31, 2017

rotemmiz Jul 31, 2017

rotemmiz Jul 31, 2017

LeoNatan Jul 31, 2017

formatlos Jul 31, 2017

formatlos Aug 11, 2017

LeoNatan Aug 11, 2017

rotemmiz Aug 13, 2017

rotemmiz Aug 13, 2017

formatlos Aug 14, 2017

rotemmiz Aug 13, 2017

formatlos commented Aug 14, 2017 •

edited

Loading

		@@ -1,4 +1,4 @@
		describe('Device', () => {
		describe.only('Device', () => {

device: add resetContentAndSettings #217

device: add resetContentAndSettings #217

Conversation

formatlos commented Jul 31, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

formatlos commented Aug 14, 2017 • edited Loading

device: add `resetContentAndSettings` #217

device: add `resetContentAndSettings` #217

formatlos commented Aug 14, 2017 •

edited

Loading