fix(android, api31): use api31 compatible transitive androidx deps #3055
Conversation
The activities exported by the libraries in the updated dependency versions correctly specify "android:exported" attributes, so apps that use Detox may successfully bump their targetSdkVersion to 31
Required a patch to Detox, tracked here: wix/Detox#3055
|
Sadly, this fails react-native 0.59 detox testing as well: https://jenkins-oss.wixpress.com/job/detox-android-59-9-pr/2397/console - it may be that react-native 0.59 is an intractable problem at this point and minimum compatible react-native could be raised |
Required a patch to Detox, tracked here: wix/Detox#3055
previously the android gradle plugin in use for tests would be 3.4.x for early react-native versions, but that appears to be incompatible with modern test deps needed for Android 12 3.6.x is the oldest compatible version of the plugin
|
Not sure what is going on with RN59 Jenkins, I was able to build the app successfully locally following the CI script 🤷 You do need the second commit that bumps up the android gradle plugin in use, as far as I can tell, but whatever the compileSdkVersion issue is I can't figure out. Spending any time at all on react-native 0.59 feels like time wasted at this point so I'm going to leave it. |
|
For anyone that needs detox to work on an app using targetSdkVersion 31 you may use the patch-package patch from this change here: https://github.com/invertase/react-native-firebase/pull/5835/files#diff-c3c4ac892ab301a8340adc456d7acef27b5ece166b125c2acd237628f4a83539 It does work! I expect this PR to superceded by #3033 though (which is great, that's a full upgrade of everything including example apps here) so the PR itself may not go anywhere even though the change is functional and works |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
The issue has been closed for inactivity. |
Description
This PR enables apps using Detox to raise targetSdkVersion to 31
The activities exported by the libraries in the updated dependency
versions correctly specify "android:exported" attributes, so apps
that use Detox may successfully bump their targetSdkVersion to 31
Related #2899 - Detox already ran on Android12 but apps using Detox could not target API31
Related #3033 - CI failures without JDK11 and is updating lots of things at once, this is focused
#3033 is useful but looks like it will take a while, this unblocks Detox-using apps right now