fix(scrollTo): raise if scroll view element is not hittable.

detox/ios/Detox.xcodeproj/project.pbxproj

@@ -112,6 +112,8 @@
  6062B5E62720323700CBDBF0 /* DTXAddressInfo.mm in Sources */ = {isa = PBXBuildFile; fileRef = 6062B5E02720323700CBDBF0 /* DTXAddressInfo.mm */; };
  60C1961A271F11C4000172DD /* fishhook.h in Headers */ = {isa = PBXBuildFile; fileRef = 60C19618271F11C4000172DD /* fishhook.h */; };
  60C1961B271F11C4000172DD /* fishhook.c in Sources */ = {isa = PBXBuildFile; fileRef = 60C19619271F11C4000172DD /* fishhook.c */; };
+ 60E149C72759038F00519EE4 /* UIResponder+First.h in Headers */ = {isa = PBXBuildFile; fileRef = 60E149C52759038F00519EE4 /* UIResponder+First.h */; };
+ 60E149C82759038F00519EE4 /* UIResponder+First.m in Sources */ = {isa = PBXBuildFile; fileRef = 60E149C62759038F00519EE4 /* UIResponder+First.m */; };
  AD4781082636F7CF006774CD /* NSURL+DetoxUtils.h in Headers */ = {isa = PBXBuildFile; fileRef = AD4781062636F7CE006774CD /* NSURL+DetoxUtils.h */; settings = {ATTRIBUTES = (Private, ); }; };
  AD4781092636F7CF006774CD /* NSURL+DetoxUtils.m in Sources */ = {isa = PBXBuildFile; fileRef = AD4781072636F7CF006774CD /* NSURL+DetoxUtils.m */; };
 /* End PBXBuildFile section */
@@ -299,6 +301,8 @@
  6062B5E02720323700CBDBF0 /* DTXAddressInfo.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = DTXAddressInfo.mm; path = DetoxSync/DetoxSync/DTXObjectiveCHelpers/DTXAddressInfo.mm; sourceTree = SOURCE_ROOT; };
  60C19618271F11C4000172DD /* fishhook.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = fishhook.h; path = DetoxSync/DetoxSync/fishhook/fishhook.h; sourceTree = SOURCE_ROOT; };
  60C19619271F11C4000172DD /* fishhook.c */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.c; name = fishhook.c; path = DetoxSync/DetoxSync/fishhook/fishhook.c; sourceTree = SOURCE_ROOT; };
+ 60E149C52759038F00519EE4 /* UIResponder+First.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "UIResponder+First.h"; sourceTree = "<group>"; };
+ 60E149C62759038F00519EE4 /* UIResponder+First.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = "UIResponder+First.m"; sourceTree = "<group>"; };
  AD4781062636F7CE006774CD /* NSURL+DetoxUtils.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "NSURL+DetoxUtils.h"; sourceTree = "<group>"; };
  AD4781072636F7CF006774CD /* NSURL+DetoxUtils.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = "NSURL+DetoxUtils.m"; sourceTree = "<group>"; };
 /* End PBXFileReference section */
@@ -525,6 +529,8 @@
  395B06E3256D5A5600941716 /* UIView+DetoxSpeedup.m */,
  AD4781062636F7CE006774CD /* NSURL+DetoxUtils.h */,
  AD4781072636F7CF006774CD /* NSURL+DetoxUtils.m */,
+ 60E149C52759038F00519EE4 /* UIResponder+First.h */,
+ 60E149C62759038F00519EE4 /* UIResponder+First.m */,
  );
  path = Utilities;
  sourceTree = "<group>";
@@ -601,6 +607,7 @@
  isa = PBXHeadersBuildPhase;
  buildActionMask = 2147483647;
  files = (
+ 60E149C72759038F00519EE4 /* UIResponder+First.h in Headers */,
  3947679C1DBF985400D72256 /* Detox.h in Headers */,
  39CA978C245B13CB00A7FC43 /* UIDevice+DetoxActions.h in Headers */,
  3980D11C2448B52C004812DD /* DTXSyntheticEvents.h in Headers */,
@@ -828,6 +835,7 @@
  396D455725238BCE0096E7FA /* UIImage+DetoxUtils.m in Sources */,
  39A34C721E30F10D00BEBB59 /* DetoxAppDelegateProxy.m in Sources */,
  39EECB7D24C0A5AF009C3364 /* NSThread+DetoxUtils.m in Sources */,
+ 60E149C82759038F00519EE4 /* UIResponder+First.m in Sources */,
  390DED84248906FC00E27BE8 /* UIWindow+DetoxUtils.m in Sources */,
  3980D158244C45EA004812DD /* Modifier.swift in Sources */,
  39EECB4324BF4FDA009C3364 /* ReactNativeSupport.m in Sources */,

detox/ios/Detox/Actions/UIDatePicker+DetoxActions.m

@@ -13,7 +13,7 @@ @implementation UIDatePicker (DetoxActions)
 
 - (void)dtx_adjustToDate:(NSDate*)date
 {
- [self dtx_assertVisible];
+ [self dtx_assertHittable];
 
  NSDate* previousDate = self.date;
 

detox/ios/Detox/Actions/UIPickerView+DetoxActions.m

@@ -14,7 +14,7 @@ @implementation UIPickerView (DetoxActions)
 
 - (void)dtx_setComponent:(NSInteger)component toValue:(id)value
 {
- [self dtx_assertVisible];
+ [self dtx_assertHittable];
 
  DTXViewAssert(self.dataSource != nil && self.delegate != nil, self.dtx_elementDebugAttributes, @"The picker view's data source and/or delegate are nil");
 

detox/ios/Detox/Actions/UIScrollView+DetoxActions.m

@@ -289,7 +289,10 @@ - (void)_dtx_scrollWithOffset:(CGPoint)offset normalizedStartingPoint:(CGPoint)n
  }
 
  CGPoint startPoint = CGPointMake(safeAreaToScroll.origin.x + safeAreaToScroll.size.width * normalizedStartingPoint.x, safeAreaToScroll.origin.y + safeAreaToScroll.size.height * normalizedStartingPoint.y);
-
+
+ CGPoint viewPoint = [self convertPoint:startPoint fromView:self.window];
+ [self dtx_assertScrollableAtPoint:viewPoint];
+
  NSUInteger successfullyAppliedScrolls = 0;
  while (offset.x != 0.0 || offset.y != 0.0)
  {
@@ -305,7 +308,16 @@ - (void)_dtx_scrollWithOffset:(CGPoint)offset normalizedStartingPoint:(CGPoint)n
  DTXViewAssert(strict == NO || successfullyAppliedScrolls > 0, self.dtx_elementDebugAttributes, @"Unable to scroll %@ in “%@”", _DTXScrollDirectionDescriptionWithOffset(offset), self.dtx_shortDescription);
 
  self.dtx_disableDecelerationForScroll = NO;
-// self.bounces = oldBounces;
+}
+
+- (void)dtx_assertScrollableAtPoint:(CGPoint)startPoint {
+ NSError *error;
+ DTXAssert([self dtx_isHittableAtPoint:startPoint error:&error],
+ @"View is not scrollable at the given start point. Start point (view coordinates): %@" \
+ "\n- Full error: %@\n----\nMore about scroll action API here: " \
+ "https://wix.github.io/Detox/docs/api/actions-on-element/" \
+ "#scrolloffset-direction-startpositionx-startpositiony",
+ NSStringFromCGPoint(startPoint), error.localizedDescription);
 }
 
 @end

detox/ios/Detox/Invocation/Element.swift

@@ -213,13 +213,7 @@ class Element : NSObject {
  }
 
  func isHittable() throws -> Bool {
- var error: NSError? = nil
- let rv = view.dtx_isHittable(at: view.dtx_accessibilityActivationPointInViewCoordinateSpace, error: &error)
- if let error = error {
- throw error
- }
-
- return rv
+ return view.dtx_isHittable
  }
 
  func takeScreenshot(fileName: String?) -> [String : Any] {

detox/ios/Detox/Policy/DetoxPolicy.h

@@ -16,8 +16,6 @@ NS_ASSUME_NONNULL_BEGIN
 @property (class, nonatomic, readonly) NSUInteger defaultPercentThresholdForVisibility;
 @property (class, nonatomic, readonly) NSUInteger consecutiveTouchPointsWithSameContentOffsetThreshold;
 
-+ (NSString*)percentDescriptionForValue:(CGFloat)value;
-
 @end
 
 NS_ASSUME_NONNULL_END

detox/ios/Detox/Policy/DetoxPolicy.m

@@ -22,16 +22,4 @@ + (NSUInteger)consecutiveTouchPointsWithSameContentOffsetThreshold {
  return 12;
 }
 
-+ (NSString*)percentDescriptionForValue:(CGFloat)value {
- static NSNumberFormatter* formatter;
- static dispatch_once_t onceToken;
- dispatch_once(&onceToken, ^{
- formatter = [NSNumberFormatter new];
- formatter.locale = [NSLocale localeWithLocaleIdentifier:@"en_US"];
- formatter.numberStyle = NSNumberFormatterPercentStyle;
- });
-
- return [formatter stringFromNumber:@(value)];
-}
-
 @end

detox/ios/Detox/Utilities/NSObject+DetoxUtils.h

@@ -33,16 +33,17 @@ static double LNLinearInterpolate(CGFloat from, CGFloat to, CGFloat p)
 @property (nonatomic, readonly) CGRect dtx_visibleBounds;
 
 - (BOOL)dtx_isVisible;
+- (void)dtx_assertVisibleWithPercent:(nullable NSNumber *)percent;
 - (BOOL)dtx_isVisibleAtRect:(CGRect)rect percent:(nullable NSNumber *)percent
- error:(NSError* __strong * __nullable)error;
+ error:(NSError* __strong __nullable * __nullable)error;
 - (void)dtx_assertVisible;
 - (void)dtx_assertVisibleAtRect:(CGRect)rect percent:(nullable NSNumber *)percent;
 
 - (BOOL)dtx_isFocused;
 
 @property (nonatomic, readonly) BOOL dtx_isHittable;
-- (BOOL)dtx_isHittableAtPoint:(CGPoint)point;
-- (BOOL)dtx_isHittableAtPoint:(CGPoint)point error:(NSError* __strong * __nullable)error;
+- (BOOL)dtx_isHittableAtPoint:(CGPoint)viewPoint
+ error:(NSError* __strong __nullable * __nullable)error;
 - (void)dtx_assertHittable;
 - (void)dtx_assertHittableAtPoint:(CGPoint)point;
 

detox/ios/Detox/Utilities/NSObject+DetoxUtils.m

@@ -41,7 +41,7 @@ static id DTXJSONSafeNSNumberOrString(double d)
 DTX_ALWAYS_INLINE
 static NSString* DTXPointToString(CGPoint point)
 {
- return [[NSString alloc] initWithData:[NSJSONSerialization dataWithJSONObject:DTXPointToDictionary(point) options:0 error:NULL] encoding:NSUTF8StringEncoding];
+ return [[NSString alloc] initWithData:[NSJSONSerialization dataWithJSONObject:DTXPointToDictionary(point) options:0 error:nil] encoding:NSUTF8StringEncoding];
 }
 
 @interface NSObject ()
@@ -137,19 +137,23 @@ - (CGRect)dtx_visibleBounds
 }
 
 - (BOOL)dtx_isVisible {
- return [self dtx_isVisibleAtRect:self.dtx_bounds percent:nil error:NULL];
+ return [self dtx_isVisibleAtRect:self.dtx_bounds percent:nil error:nil];
 }
 
 - (BOOL)dtx_isVisibleAtRect:(CGRect)rect percent:(nullable NSNumber *)percent
- error:(NSError *__strong  _Nullable *)error {
+ error:(NSError* __strong __nullable * __nullable)error {
  return [self.dtx_view dtx_isVisibleAtRect:rect percent:percent error:error];
 }
 
 - (void)dtx_assertVisible {
- [self dtx_assertVisibleAtRect:self.dtx_bounds percent:nil];
+ [self dtx_assertVisibleWithPercent:nil];
 }
 
-- (void)dtx_assertVisibleAtRect:(CGRect)rect percent:(NSNumber *)percent {
+- (void)dtx_assertVisibleWithPercent:(nullable NSNumber *)percent {
+ [self dtx_assertVisibleAtRect:self.dtx_bounds percent:percent];
+}
+
+- (void)dtx_assertVisibleAtRect:(CGRect)rect percent:(nullable NSNumber *)percent {
  [self.dtx_view dtx_assertVisibleAtRect:rect percent:percent];
 }
 
@@ -165,25 +169,14 @@ - (BOOL)dtx_isHittable
  return YES;
 }
 
-- (BOOL)dtx_isHittableAtPoint:(CGPoint)point
-{
- return YES;
+- (BOOL)dtx_isHittableAtPoint:(CGPoint)viewPoint
+ error:(NSError* __strong __nullable * __nullable)error {
+ return YES;
 }
 
-- (BOOL)dtx_isHittableAtPoint:(CGPoint)point error:(NSError* __strong * __nullable)error
-{
- return YES;
-}
+- (void)dtx_assertHittable {}
 
-- (void)dtx_assertHittable
-{
-
-}
-
-- (void)dtx_assertHittableAtPoint:(CGPoint)point
-{
-
-}
+- (void)dtx_assertHittableAtPoint:(CGPoint)point {}
 
 - (NSString *)dtx_text
 {
@@ -267,7 +260,7 @@ - (CGPoint)dtx_accessibilityActivationPointInViewCoordinateSpace
  {
  return;
  }
- 
+
  if([key isEqualToString:@"dtx_text"])
  {
  rv[@"text"] = obj;
@@ -379,9 +372,9 @@ - (CGPoint)dtx_accessibilityActivationPointInViewCoordinateSpace
  return rv;
 }
 
-- (NSDictionary<NSString *,id> *)dtx_elementDebugAttributes
+- (NSDictionary<NSString *, id> *)dtx_elementDebugAttributes
 {
- NSMutableDictionary* rv = [NSMutableDictionary new];
+ NSMutableDictionary<NSString *, id> *rv = [NSMutableDictionary new];
  [rv addEntriesFromDictionary:NSObject.dtx_genericElementDebugAttributes];
 
  rv[@"elementAttributes"] = [self dtx_attributes];

detox/ios/Detox/Utilities/UIResponder+First.h

@@ -0,0 +1,21 @@
+//
+// UIResponder+First.h
+// Detox
+//
+// Created by Asaf Korem on 02/12/2021.
+// Copyright © 2021 Wix. All rights reserved.
+//
+
+#import <Foundation/Foundation.h>
+
+NS_ASSUME_NONNULL_BEGIN
+
+@interface UIResponder (First)
+
+/// Finds the first reponder.
+/// @see https://stackoverflow.com/a/21330810/11686340
++ (instancetype)dtx_first;
+
+@end
+
+NS_ASSUME_NONNULL_END

detox/ios/Detox/Utilities/UIResponder+First.m

@@ -0,0 +1,26 @@
+//
+// UIResponder+First.m
+// Detox
+//
+// Created by Asaf Korem on 02/12/2021.
+// Copyright © 2021 Wix. All rights reserved.
+//
+
+#import "UIResponder+First.h"
+
+static __weak UIResponder *_dtx_first;
+
+@implementation UIResponder (First)
+
++ (instancetype)dtx_first {
+ _dtx_first = nil;
+ [[UIApplication sharedApplication] sendAction:@selector(responderAction:) to:nil from:nil
+ forEvent:nil];
+ return _dtx_first;
+}
+
+- (void)responderAction:(id)sender {
+ _dtx_first = self;
+}
+
+@end