-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scrollTo): raise if scroll view element is not hittable. #3115
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
1b3e71c
fix(34.visibility.test.js): await for element matching.
asafkorem 6302a4b
fix(DetoxPolicy): remove `percentDescriptionForValue` method.
asafkorem 9b0c874
iOS(Test App): add native method for presenting overlay window.
asafkorem b78b551
iOS(Test App): write failed detox tests (to reproduce #2834).
asafkorem abdc4fe
fix(iOS): rewrite `isHittable` check logic.
asafkorem 0c65205
fix(DetoxActions): use is-hittable assertion before UI gestures.
asafkorem 5e055c4
fix(isHittable): check if view is hittable from first responder.
asafkorem 1ad2a7a
UIView+DetoxUtils: remove redundant EL.
asafkorem 2063212
fix(actions): use the correct coordinates systems.
asafkorem 41beed4
fix(DetoxUtils): fix `error` handling.
asafkorem ae83497
fix(DetoxUtils): add nullable flag to error's value.
asafkorem 44bfaa5
UIResponder+First: add reference to the source SO thread.
asafkorem 24b9992
UIScrollView+DetoxActions: make informative assertion.
asafkorem adfe875
03.actions.test.js: add expectations.
asafkorem ad36fe3
03.actions-scroll.test.js: add tests for covered scroll view.
asafkorem 2813ef1
03.actions-scroll.test.js: fix android test fail (due to timeout).
asafkorem 7d12668
03.actions.test.js: expect only on iOS.
asafkorem 1d67fe5
Publish 19.3.0-smoke.0 [ci skip]
mobile1-internal 281cd54
03.actions.test.js: replace TODOs with reference to issue.
asafkorem 43e7ee6
fix(33.attributes.test.js): expect both subviews to be hittable.
asafkorem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// | ||
// UIResponder+First.h | ||
// Detox | ||
// | ||
// Created by Asaf Korem on 02/12/2021. | ||
// Copyright © 2021 Wix. All rights reserved. | ||
// | ||
|
||
#import <Foundation/Foundation.h> | ||
|
||
NS_ASSUME_NONNULL_BEGIN | ||
|
||
@interface UIResponder (First) | ||
|
||
/// Finds the first reponder. | ||
/// @see https://stackoverflow.com/a/21330810/11686340 | ||
+ (instancetype)dtx_first; | ||
|
||
@end | ||
|
||
NS_ASSUME_NONNULL_END |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
// | ||
// UIResponder+First.m | ||
// Detox | ||
// | ||
// Created by Asaf Korem on 02/12/2021. | ||
// Copyright © 2021 Wix. All rights reserved. | ||
// | ||
|
||
#import "UIResponder+First.h" | ||
|
||
static __weak UIResponder *_dtx_first; | ||
|
||
@implementation UIResponder (First) | ||
|
||
+ (instancetype)dtx_first { | ||
_dtx_first = nil; | ||
[[UIApplication sharedApplication] sendAction:@selector(responderAction:) to:nil from:nil | ||
forEvent:nil]; | ||
return _dtx_first; | ||
} | ||
|
||
- (void)responderAction:(id)sender { | ||
_dtx_first = self; | ||
} | ||
|
||
@end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ref stackoverflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v