fix(ios): ignore "nothing to terminate" simctl error #3551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
d4vidi
requested review from
asafkorem
and removed request for
noomorph and
d4vidi
asafkorem
approved these changes
Aug 14, 2022
Comment on lines
+249
to
+251
| if (err.code === 3 && | ||
| (err.stderr.includes(`the app is not currently running`) || | ||
| err.stderr.includes(`The operation couldn’t be completed. found nothing to terminate`))) { |
There was a problem hiding this comment.
They probably changed this error message in the latest CLI tools versions. That's a new error that they introduced recently https://developer.apple.com/forums/thread/699615
|
Huge thanks @mikehardy! |
1 task
|
Thanks for the link to the upstream issue on messaging, that explains why this only started showing up for me recently, but was not dependent on (for instance) trying Xcode 14 beta (which I'm also giving a look at from time to time) Either way, happy to help, you all have my continued appreciation for maintaining Detox! Cheers |
|
Version 19.9.2 was released with this patch 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was having problems running my detox tests in CI (but not locally?) that looked exactly like #3518 and it seemed easy enough to patch, so I tried it and it seems to work for me.
Unsure on formatting here but either CI will tell me or you all will :-) - I was hacking it locally via patch-package so don't have devtools for the repo set up + available at the moment sorry
@asafkorem you marked this as assigned to yourself, so perhaps you want to give it a look?
Fixes #3518 (I think - it does for me anyway)