-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: avd validator emulator version should obey headless
#3614
Conversation
Unit tests? nothing to change? |
@noomorph Hi, I've added two test cases and fixed the broken one 😄 |
@d4vidi @asafkorem please review the unit tests for quality (I'm a bit worried about non-explicitness of expected booleans there, e.g.: |
@paulrostorp thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good to me, minor suggestion, and we can merge it.
detox/src/devices/allocation/drivers/android/emulator/EmulatorAllocDriver.test.js
Outdated
Show resolved
Hide resolved
This is a bug-fix to address the `headless` config when running tests (invoked as `emulator -version`) by the AVD emulator version validator. Resolves #3613
Thanks @paulrostorp, Detox v19.12.4 was released with your fix 👑 |
* feat: set minimal Node requirement to 14.5.x * feat: drop old Jest integrations BREAKING CHANGE: please upgrade to jest-circus https://wix.github.io/Detox/docs/guide/jest/ * feat(config): drop default "e2e" value for specs (#3289) BREAKING CHANGE: Detox won't be appending "e2e" glob to the test runner if it is not explicitly configured to do so via "specs" property in the config. * feat(config): drop skipLegacyWorkersInjection (#3286) BREAKING CHANGE: Detox will no longer be injecting "-w 1" to Jest as CLI arguments * feat(android): boot read-only emulators by default * feat(iOS): support --headless config (#3304) BREAKING: opens Simulator app by default unless the headless mode is enabled * feat: drop Mocha support (#3310) BREAKING: Detox users should migrate to Jest * feat(android): remove deprecated native IdlePolicyConfig (#3332) BREAKING CHANGE * feat: drop device.appLaunchArgs [options] argument (#3360) BREAKING: use device.appLaunchArgs.shared for permanent operations * feat: remove ios.none device type (#3361) * feat: undeprecate device.relaunchApp() (#3362) * feat(config): remove legacy dash-based props (#3371) BREAKING: removes test-runner and runner-config props from Detox global config. Use testRunner and runnerConfig instead. * feat(config): drop support for the all-in-one configuration format (#3386) BREAKING: please migrate to the new { apps, devices, configurations } schema that Detox has been already using for more than a year. * feat: drop jest<27.2.5 support (#3392) BREAKING: please migrate your projects to Jest 28.x or 27.x * fix(ios): headless mode * feat: new global lifecycle for Detox (#3333) * fix(cli): forward env overrides anyway * feat(config): add testRunner.forwardEnv Also, fixes --inspect-brk debugging experience. Now the entire debug happens in a single test runner process. * feat(api): detoxInternals.tracing.createEventStream * feat(config): add reversePorts to app config (#3610) * fix(Android): pass `headless` config param to the AVD validator. (#3614) * feat(cli): add reset-lock-file command * website: add Showcase page * website: homepage changes * feat(cli): drop --device-launch-args arg (#3665) BREAKING: use --device-boot-args instead Co-authored-by: Asaf Korem <asaf.korem@gmail.com> Co-authored-by: d4vidi <amit.d4vidi@gmail.com> Co-authored-by: jasonbariwix <jasonba@wix.com> Co-authored-by: Yevheniia Hlovatska <33955728+evgeniyaglovatskaya@users.noreply.github.com>
Description
This is a bugfix to address the
headless
config when running tests (invoked asemulator -version
by theAVDValidator
s emulator version validator.headless
not respected by AVDValidator emulator version validator #3613In this pull request, I have forwarded the
headless
config option to theAVDValidator
so that the existing emulator version query can operate as expected and in accordance to the configuration provided by the user