Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade/rn72 final #4336

Merged
merged 37 commits into from
Jan 21, 2024
Merged

Upgrade/rn72 final #4336

merged 37 commits into from
Jan 21, 2024

Conversation

gosha212
Copy link
Contributor

@gosha212 gosha212 commented Jan 15, 2024

Description

This pull request fixes #4157, fixes #4158, fixes #4156, fixes #4155, fixes #4160

In this pull request, I have added support to RN 72 with backward compatibility to RN 71


For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

For API changes:

  • I have made the necessary changes in the types index file.

@gosha212 gosha212 marked this pull request as ready for review January 15, 2024 18:40
Copy link
Collaborator

@d4vidi d4vidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey looks really good, but requires some subtle fixed. Please review 🙏🏻

.buildkite/jobs/pipeline.android_rn_72.yml Show resolved Hide resolved
detox/android/build.gradle Show resolved Hide resolved
examples/demo-react-native/android/settings.gradle Outdated Show resolved Hide resolved
detox/test/src/Screens/AttributesScreen.js Outdated Show resolved Hide resolved
examples/demo-react-native/ios/Podfile Outdated Show resolved Hide resolved
detox/test/ios/Podfile Outdated Show resolved Hide resolved
detox/test/ios/Podfile Outdated Show resolved Hide resolved
detox/test/e2e/utils/custom-it.js Outdated Show resolved Hide resolved
@gosha212 gosha212 merged commit cbc5631 into master Jan 21, 2024
7 checks passed
@d4vidi
Copy link
Collaborator

d4vidi commented Jan 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants