-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Website: show instructions side by side #587
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Update from my side: I will be working on it this evening |
I am continuing the work on this right now 👍 |
3c7a08a
to
5ea0091
Compare
Status: Still need to use the component, but it looks okay-ish in the storybook :) |
0a3d839
to
57b874b
Compare
Oh man, this is harder then it seemed -.- But we are getting there, had to remove styled components as they didn't work well with docusaurus. Now somehow the included component is not dynamic, it doesn't do anything on click. This needs more investigation on my side. |
It's a big luck we have a professional on this then 😉 |
Uh nice, who is it? |
Asking for help is our best option here, I wrote a demo, will keep you posted: facebook/docusaurus#584 |
@rotemmiz Outcome of the ticket on Docusaurus was that they don't rehydrate react, so they don't support interactivity in their documentations. We can go different routes from here:
|
Closing this for now |
This PR aims to show the install instructions side by side, similar to the react-native docs.