Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fixing Android support for demo-react-native example project #593

Closed
wants to merge 1 commit into from

Conversation

chrmod
Copy link

@chrmod chrmod commented Feb 28, 2018

Having problems with running Android tests on Travis CI, we tried to get any of the example projects, but without luck. This PR aims to update demo-react-native project to run Android tests.

Submitter version works, but requires some cleanups.

@rotemmiz
Copy link
Member

rotemmiz commented Mar 7, 2018

Hey @chrmod , thanks for the PR!
Demo projects were updated recently to run most recent configuration. If you still see anything missing, please rebase this PR and submit again.

@chrmod
Copy link
Author

chrmod commented Mar 7, 2018

Hi @rotemmiz thanks for info, I will check that soon.
Can you please take a look on the issue I've opened on state of Android CI #594
The purpose of this PR was to ensure you can use detox for Android and what we've found out is that it works fine when run on MacOS but does not work on Linux.

@rotemmiz
Copy link
Member

Closing this PR as the projects are mostly updated.
Feel free to reopen after rebasing if you want to change things currently on master.

@rotemmiz rotemmiz closed this Mar 11, 2018
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants