-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: perform actions on UIPickerView #605
Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f708294
functionality for datePicker IOS
DmitryPonomarenko 41e6034
current work
DmitryPonomarenko 2eaabda
add setColumnToValue method
DmitryPonomarenko 1b7cb17
delete testID
DmitryPonomarenko 79bf393
Merge branch 'master' into FunctionalityForTestingPickerIOS
DmitryPonomarenko 1a4d56f
add description for ActionsOnElement, delete expect for action
DmitryPonomarenko 363bc2b
Merge branch 'master' into FunctionalityForTestingPickerIOS
DmitryPonomarenko bd01ad0
add checking data after scrolling datePicker
DmitryPonomarenko e9a7abe
updates
DmitryPonomarenko cb87e43
changes
DmitryPonomarenko 604b1ff
Merge branch 'master' into FunctionalityForTestingPickerIOS
DmitryPonomarenko b6db95d
delete team
DmitryPonomarenko ae1d48e
Update s-datePicker.js
LeoNatan 02526c9
Discard changes in this file
LeoNatan 0a9d71d
unit tests
DmitryPonomarenko 46c5702
test new functionality
DmitryPonomarenko 073140e
Merge branch 'master' into FunctionalityForTestingPickerIOS
DmitryPonomarenko 98d3eb7
Merge branch 'master' into FunctionalityForTestingPickerIOS
DmitryPonomarenko 087d2ba
fixed unit test
rotemmiz a22bbeb
Update APIRef.ActionsOnElement.md
LeoNatan 6770cd4
Update APIRef.ActionsOnElement.md
LeoNatan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
describe('DatePicker', () => { | ||
beforeEach(async () => { | ||
await device.reloadReactNative(); | ||
}); | ||
|
||
beforeEach(async () => { | ||
await element(by.text('DatePicker')).tap(); | ||
}); | ||
|
||
it('datePicker and dateLabel should be visible', async () => { | ||
await expect(element(by.type('UIPickerView'))).toBeVisible(); | ||
await expect(element(by.id('timeLabel'))).toBeVisible(); | ||
}); | ||
|
||
it('datePicker should be scroll and change time', async () => { | ||
await element(by.type('UIPickerView')).setColumnToValue(1,"6"); | ||
await element(by.type('UIPickerView')).setColumnToValue(2,"34"); | ||
await expect(element(by.id("timeLabel"))).toHaveText('choosenTime is 6:34'); | ||
}); | ||
|
||
}); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -328,34 +328,6 @@ | |
remoteGlobalIDString = 58B5119B1A9E6C1200147676; | ||
remoteInfo = RCTText; | ||
}; | ||
D58447AF204E9C6000248543 /* PBXContainerItemProxy */ = { | ||
isa = PBXContainerItemProxy; | ||
containerPortal = 146833FF1AC3E56700842450 /* React.xcodeproj */; | ||
proxyType = 2; | ||
remoteGlobalIDString = EBF21BDC1FC498900052F4D5; | ||
remoteInfo = jsinspector; | ||
}; | ||
D58447B1204E9C6000248543 /* PBXContainerItemProxy */ = { | ||
isa = PBXContainerItemProxy; | ||
containerPortal = 146833FF1AC3E56700842450 /* React.xcodeproj */; | ||
proxyType = 2; | ||
remoteGlobalIDString = EBF21BFA1FC4989A0052F4D5; | ||
remoteInfo = "jsinspector-tvOS"; | ||
}; | ||
D58447B3204E9C6000248543 /* PBXContainerItemProxy */ = { | ||
isa = PBXContainerItemProxy; | ||
containerPortal = 146833FF1AC3E56700842450 /* React.xcodeproj */; | ||
proxyType = 2; | ||
remoteGlobalIDString = 9936F3131F5F2E4B0010BF04; | ||
remoteInfo = privatedata; | ||
}; | ||
D58447B5204E9C6000248543 /* PBXContainerItemProxy */ = { | ||
isa = PBXContainerItemProxy; | ||
containerPortal = 146833FF1AC3E56700842450 /* React.xcodeproj */; | ||
proxyType = 2; | ||
remoteGlobalIDString = 9936F32F1F5F2E5B0010BF04; | ||
remoteInfo = "privatedata-tvOS"; | ||
}; | ||
/* End PBXContainerItemProxy section */ | ||
|
||
/* Begin PBXCopyFilesBuildPhase section */ | ||
|
@@ -1060,34 +1032,6 @@ | |
remoteRef = 832341B41AAA6A8300B99B32 /* PBXContainerItemProxy */; | ||
sourceTree = BUILT_PRODUCTS_DIR; | ||
}; | ||
D58447B0204E9C6000248543 /* libjsinspector.a */ = { | ||
isa = PBXReferenceProxy; | ||
fileType = archive.ar; | ||
path = libjsinspector.a; | ||
remoteRef = D58447AF204E9C6000248543 /* PBXContainerItemProxy */; | ||
sourceTree = BUILT_PRODUCTS_DIR; | ||
}; | ||
D58447B2204E9C6000248543 /* libjsinspector-tvOS.a */ = { | ||
isa = PBXReferenceProxy; | ||
fileType = archive.ar; | ||
path = "libjsinspector-tvOS.a"; | ||
remoteRef = D58447B1204E9C6000248543 /* PBXContainerItemProxy */; | ||
sourceTree = BUILT_PRODUCTS_DIR; | ||
}; | ||
D58447B4204E9C6000248543 /* libprivatedata.a */ = { | ||
isa = PBXReferenceProxy; | ||
fileType = archive.ar; | ||
path = libprivatedata.a; | ||
remoteRef = D58447B3204E9C6000248543 /* PBXContainerItemProxy */; | ||
sourceTree = BUILT_PRODUCTS_DIR; | ||
}; | ||
D58447B6204E9C6000248543 /* libprivatedata-tvOS.a */ = { | ||
isa = PBXReferenceProxy; | ||
fileType = archive.ar; | ||
path = "libprivatedata-tvOS.a"; | ||
remoteRef = D58447B5204E9C6000248543 /* PBXContainerItemProxy */; | ||
sourceTree = BUILT_PRODUCTS_DIR; | ||
}; | ||
/* End PBXReferenceProxy section */ | ||
|
||
/* Begin PBXResourcesBuildPhase section */ | ||
|
@@ -1193,7 +1137,7 @@ | |
buildSettings = { | ||
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; | ||
DEAD_CODE_STRIPPING = NO; | ||
DEVELOPMENT_TEAM = ""; | ||
DEVELOPMENT_TEAM = S3GLW74Y8N; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't understand why these changes are going in? |
||
INFOPLIST_FILE = example/Info.plist; | ||
IPHONEOS_DEPLOYMENT_TARGET = 9.0; | ||
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks"; | ||
|
@@ -1210,7 +1154,7 @@ | |
isa = XCBuildConfiguration; | ||
buildSettings = { | ||
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; | ||
DEVELOPMENT_TEAM = ""; | ||
DEVELOPMENT_TEAM = S3GLW74Y8N; | ||
INFOPLIST_FILE = example/Info.plist; | ||
IPHONEOS_DEPLOYMENT_TARGET = 9.0; | ||
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks"; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,6 +28,6 @@ export { | |
NetworkScreen, | ||
AnimationsScreen, | ||
LocationScreen, | ||
ShakeScreen | ||
ShakeScreen, | ||
DatePickerScreen | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not necessary.