iOS: Add support for userActivity API #623
Conversation
Add test for including more than one payload
| @@ -23,7 +23,7 @@ describe(':ios: User Notifications', () => { | |||
| await expect(element(by.text('From calendar'))).toBeVisible(); | |||
| }); | |||
|
|
|||
| it('Foreground push notifications', async () => { | |||
| it.only('Foreground push notifications', async () => { | |||
rotemmiz
changed the title
LeoNatan
changed the title
LeoNatan
changed the title
|
Hm, something failed for RN53. Will look romorrow. |
- added the "very important for our customers!" debug class
| @@ -123,6 +113,20 @@ class Device { | |||
| return !params.delete && !params.newInstance && this._processes[_bundleId]; | |||
| } | |||
|
|
|||
| _assertHasSingleParam(singleParams, params) { | |||
There was a problem hiding this comment.
Isn't the "assert" moniker incorrect if it has the side-effect of returning the count? Should be "count" and the throw should be in the calling method.
detox/src/devices/Device.js
Outdated
| async _sendPayload(key, params) { | ||
| const payloadFilePath = this.deviceDriver.createPayloadFile(params); | ||
| let payload = {}; | ||
| //JS does not support {key: "asd"} JSON generation where the `key` is a variable 🤦♂️ | ||
| //JS does not support {key: "asd"} JSON generation where the `key` is a variable |
There was a problem hiding this comment.
Not done yet...
- There's Android client to align to the protocol changes
|
If the tests fail, just restart the specific build that failed. I've been doing that for a few times. Travis… |
LeoNatan
changed the title
|
Android is all good. When CI is green, let's merge |
detox/src/devices/Device.js
Outdated
| @@ -187,7 +184,6 @@ class Device { | |||
| async _sendPayload(key, params) { | |||
| const payloadFilePath = this.deviceDriver.createPayloadFile(params); | |||
| let payload = {}; | |||
| //JS does not support {key: "asd"} JSON generation where the `key` is a variable | |||
There was a problem hiding this comment.
Why was this removed? This line is important, otherwise I might be confused like before. There is nothing logical about JS.
There was a problem hiding this comment.
Then let's write a manifest about everything that's broken in JavaScript, it's not gonna be a short one...
The tests protect this specific thing from a wrong change.
There was a problem hiding this comment.
Why is this comment bothering you?
rotemmiz
changed the title
At first will only include associated domain user activity, but will be extensible.
For this, I merged
openURL()andsendUserNotification()internally todeliverPayload(). The newuserActivity()API will use that same mechanism.Closes #622
Also fixed #601 in this branch