Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be explicit about supported RN versions #773

Merged
merged 5 commits into from
Jun 13, 2018
Merged

be explicit about supported RN versions #773

merged 5 commits into from
Jun 13, 2018

Conversation

vonovak
Copy link
Contributor

@vonovak vonovak commented Jun 5, 2018

motivation: readme contains information about supported versions and it should be more explicit because:

  • Currently is says "React Native versions 0.44 and above are supported." and the readme wasn't updated in 5 months, so it certainly wasn't correct in the time when 0.50 wasn't working on android.
  • It also isn't "future-proof" because whenever a new RN version is released, the sentence automatically makes user think the new version is supported which may not be true

For people like me who occasionally come to the repo to check if their RN version is supported, this will be a big help that will save time digging through issues.

I based the table contents on this comment, not sure what the supported versions really are.

@vonovak vonovak requested a review from rotemmiz as a code owner June 5, 2018 13:09
@noomorph
Copy link
Collaborator

Might be related to #774

@rotemmiz
Copy link
Member

Instead of using RN as a point of reference, let's use platform as point of reference.
Documentation is still missing data on what APIs exist on iOS and what APIs exist on Android. I intend to create such a list in the near future, and I want yours to align with it.

iOS Android
>=0.55 <=0.51

@vonovak
Copy link
Contributor Author

vonovak commented Jun 11, 2018

thanks for the comment @rotemmiz, you table structure makes much more sense. I have changed the PR in accordance to it., I just switched the inequality sign in the iOS column because I believe it should be <=0.55 (?).

If there are some more tricks in the supported versions, we can further break the table by also including detox version column on the left.

@rotemmiz rotemmiz merged commit acf2333 into wix:master Jun 13, 2018
@markhu
Copy link

markhu commented Jun 25, 2018

So just to be perfectly clear: Detox won't work in Android for any version of React Native newer than 51, i.e. since December 2017.

@noomorph noomorph mentioned this pull request Jun 26, 2018
@rborn
Copy link

rborn commented Jul 11, 2018

@markhu @rotemmiz @vonovak I have "detox": "^7.4.0" running with "react-native": "0.55.4" on android

I will test with "detox": "^8.0.0" and update you.

@rborn
Copy link

rborn commented Jul 12, 2018

@markhu @rotemmiz @vonovak
I updated to 8.0.0 but I get an error:

 11: running "/Work/sdks/android-sdk-macosx/platform-tools/adb -s 192.168.57.101:5555 shell ps -AMo NAME,PID" returned undefined

It doesn't seem to be related to the ReactNative version though.

@rotemmiz
Copy link
Member

This is unrelated to this PR.
Please open a new issue with full logs for that.
Moreover, add your ADB version, emulator version and device API level.

@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants