-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
be explicit about supported RN versions #773
Conversation
Might be related to #774 |
Instead of using RN as a point of reference, let's use platform as point of reference.
|
thanks for the comment @rotemmiz, you table structure makes much more sense. I have changed the PR in accordance to it., I just switched the inequality sign in the iOS column because I believe it should be <=0.55 (?). If there are some more tricks in the supported versions, we can further break the table by also including detox version column on the left. |
So just to be perfectly clear: Detox won't work in Android for any version of React Native newer than 51, i.e. since December 2017. |
This is unrelated to this PR. |
motivation: readme contains information about supported versions and it should be more explicit because:
For people like me who occasionally come to the repo to check if their RN version is supported, this will be a big help that will save time digging through issues.
I based the table contents on this comment, not sure what the supported versions really are.