ExpandableCalendar - Added height calculation on layout instead of hard coded header height #2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Inbal-Tish , I've passed the onLayout to the headers - Calendar's header when there is not staticHeader and static header when there is. I Also moved the WeekCalendar to be on top of the AnimatedHeader because it was cutting it. Do you think I should add the onHeaderLayout to the animated header instead? They should be same... I'm not sure which one is better to relay on. |
|
Do you have any intuition on things I should check here? |
Inbal-Tish
reviewed
Feb 9, 2025
Inbal-Tish
reviewed
Feb 9, 2025
Inbal-Tish
reviewed
Feb 9, 2025
Inbal-Tish
reviewed
Feb 9, 2025
Inbal-Tish
reviewed
Feb 9, 2025
Inbal-Tish
reviewed
Feb 10, 2025
Inbal-Tish
reviewed
Feb 11, 2025
nitzanyiz
changed the title
… remove useHeaderHeight hook
nitzanyiz
commented
Feb 19, 2025
Inbal-Tish
reviewed
Feb 23, 2025
Inbal-Tish
reviewed
Feb 23, 2025
Inbal-Tish
reviewed
Feb 23, 2025
Inbal-Tish
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added dynamic header height calculation. The header height had a fixed height until now causing the
WeekCalendarto go on top of the header and cut some of the calendar header. We've encountered this where theWeekCalendarwas cutting the days letters.Ticket: MADS-4584