Fix updateProps creating new props object (#6280)

updateProps deep cloned props thus rendering instance comparisons useless. closes #6262
wix · Jun 10, 2020 · b1a1e0d · b1a1e0d
1 parent 91fda4f
commit b1a1e0d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/lib/src/commands/Commands.ts b/lib/src/commands/Commands.ts
@@ -65,8 +65,7 @@ export class Commands {
   }
 
   public updateProps(componentId: string, props: object) {
-    const input = cloneDeep(props);
-    this.store.updateProps(componentId, input);
+    this.store.updateProps(componentId, props);
     this.commandsObserver.notify('updateProps', { componentId, props });
   }
 

diff --git a/lib/src/components/ComponentWrapper.tsx b/lib/src/components/ComponentWrapper.tsx
@@ -1,6 +1,5 @@
 import * as React from 'react';
 import { ComponentProvider } from 'react-native';
-import merge from 'lodash/merge';
 import { polyfill } from 'react-lifecycles-compat';
 import hoistNonReactStatics from 'hoist-non-react-statics';
 
@@ -28,7 +27,10 @@ export class ComponentWrapper {
     class WrappedComponent extends React.Component<HocProps, HocState> {
       static getDerivedStateFromProps(nextProps: any, prevState: HocState) {
         return {
-          allProps: merge({}, nextProps, store.getPropsForId(prevState.componentId))
+          allProps: {
+            ...nextProps,
+            ...store.getPropsForId(prevState.componentId)
+          }
         };
       }