Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to update props for a specific custom component #5612

Merged
merged 4 commits into from
Oct 29, 2019

Conversation

justtal
Copy link
Member

@justtal justtal commented Oct 28, 2019

This PR adds support to update props of screen or custom button/title via the mergeOptions api.

Navigation.mergeOptions('myComponentId', {
  passProps: {
    text: 'new value'
  }
});

lib/src/commands/OptionsProcessor.test.ts Outdated Show resolved Hide resolved
lib/src/components/ComponentWrapper.tsx Outdated Show resolved Hide resolved
lib/src/components/ComponentWrapper.tsx Show resolved Hide resolved
lib/src/components/Store.test.ts Outdated Show resolved Hide resolved
lib/src/components/Store.test.ts Outdated Show resolved Hide resolved
lib/src/components/Store.test.ts Show resolved Hide resolved
lib/src/components/Store.test.ts Outdated Show resolved Hide resolved
lib/src/components/Store.ts Show resolved Hide resolved
lib/src/components/Store.ts Show resolved Hide resolved
@justtal justtal force-pushed the custom-component-update-props branch from 792dd03 to 24d25d9 Compare October 29, 2019 14:28
@guyca guyca merged commit 291f161 into master Oct 29, 2019
@guyca guyca deleted the custom-component-update-props branch October 29, 2019 15:06
guyca pushed a commit that referenced this pull request Oct 31, 2019
This commit adds support to update props of screen or custom button/title via the mergeOptions api.

```js
Navigation.mergeOptions('myComponentId', {
  passProps: {
    text: 'new value'
  }
});
```
# Conflicts:
#	lib/src/interfaces/Options.ts
#	playground/src/screens/OptionsScreen.js
#	playground/src/screens/index.js
vshkl pushed a commit to vshkl/react-native-navigation that referenced this pull request Feb 5, 2020
This commit adds support to update props of screen or custom button/title via the mergeOptions api.

```js
Navigation.mergeOptions('myComponentId', {
  passProps: {
    text: 'new value'
  }
});
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants