Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss all modals before app start to ensure this use case does not break #6152

Merged
merged 3 commits into from
Apr 23, 2020

Conversation

guyca
Copy link
Collaborator

@guyca guyca commented Apr 22, 2020

This commit adds a call to dismissAllModals before setRoot to ensure this use case doesn't break in the future.

…break

This commit adds a call to dismissAllModals before setRoot to ensure this use case doesn't break in the future.
@guyca guyca requested a review from yogevbd April 22, 2020 11:17
@yogevbd yogevbd merged commit 81d01a0 into master Apr 23, 2020
@yogevbd yogevbd deleted the dismissAllModalsBeforeSetRoot branch April 23, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants