Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass componentId on showModal completion callback #6579

Merged
merged 3 commits into from
Sep 14, 2020
Merged

Pass componentId on showModal completion callback #6579

merged 3 commits into from
Sep 14, 2020
+1 −1

Conversation

danilobuerger
Copy link
Collaborator

The typedef of RNNTransitionWithComponentIdCompletionBlock:

typedef void (^RNNTransitionWithComponentIdCompletionBlock)(NSString * _Nonnull componentId);

requires the completion handler to be called with a non-null string.

@ItsNoHax ItsNoHax requested a review from yogevbd September 13, 2020 21:18
@guyca guyca merged commit 4c0528b into wix:master Sep 14, 2020
@guyca guyca deleted the modal-completion branch October 18, 2020 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogevbd yogevbd

Assignees
No one assigned
Labels
platform: iOS type: accepted/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danilobuerger @yogevbd @guyca