Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animate text change in shared element transition only if texts are lexically equal #6640

Merged
merged 3 commits into from
Oct 3, 2020
Merged

Animate text change in shared element transition only if texts are lexically equal #6640

merged 3 commits into from
Oct 3, 2020

Conversation

guyca
Copy link
Collaborator

@guyca guyca commented Oct 3, 2020

Text change was animated even if the texts were not lexically equal.
Fixes #6638

@guyca guyca changed the title Animate text change in shared element transition only if text length is equal Animate text change in shared element transition only if texts are lexically equal Oct 3, 2020
@guyca guyca force-pushed the fixTextChangeAnimator branch from a9b01ba to 7337d81 Compare October 3, 2020 07:27
@guyca guyca requested a review from mrousavy October 3, 2020 09:24
mrousavy
mrousavy approved these changes Oct 3, 2020
View reviewed changes
Copy link
Collaborator

@mrousavy mrousavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in my app, works perfectly.

@guyca guyca merged commit fd32d8e into master Oct 3, 2020
@guyca guyca deleted the fixTextChangeAnimator branch October 3, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrousavy mrousavy mrousavy approved these changes

Assignees

@mrousavy mrousavy

Labels
feature: Shared Element Transition platform: Android type: accepted/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StringIndexOutOfBoundsException on shared element transition
2 participants
@guyca @mrousavy