Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link script on iOS #6674

Merged
merged 6 commits into from
Oct 15, 2020
Merged

Fix link script on iOS #6674

merged 6 commits into from
Oct 15, 2020

Conversation

yogevbd
Copy link
Collaborator

@yogevbd yogevbd commented Oct 15, 2020

Sets the minimum iOS version to iOS 11.0 which is the minimum version required by the library.

@yogevbd yogevbd requested review from danilobuerger and removed request for guyca October 15, 2020 10:56
danilobuerger
danilobuerger previously approved these changes Oct 15, 2020
Copy link
Collaborator

@danilobuerger danilobuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although as previously discussed could have side effects if the podfile was previously modified. This could alter the platform of other targets or downgrade the version if previously set higher.

@yogevbd
Copy link
Collaborator Author

yogevbd commented Oct 15, 2020

@danilobuerger nice catch! fixed.

@yogevbd yogevbd requested a review from danilobuerger October 15, 2020 11:48
@danilobuerger
Copy link
Collaborator

Looks good, didn't test though.

@yogevbd
Copy link
Collaborator Author

yogevbd commented Oct 15, 2020

@danilobuerger tested it in multiple cases so I think we're good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants