Remove unnecessary overrides to setDefaultOptions, apply defaultOptions to RNNSideMenuController #6691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An e2e test relies on rotating the side menu screen and checks for a certain height of the side menu. Through the bugfix, this screen no longer rotated and presented fullscreen as it was now adhering to the default options.
danilobuerger
force-pushed
the
defaultoptions
branch
from
b935be8 to
caf3261
Compare
yogevbd
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setDefaultOptionsfrom RNNBasePresenter. This is already covered by the synthesizeddefaultOptionsprop.[presenter setDefaultOptions:]to the default implementation in order to remove all the overrides that do the same thing.Notice that the override implementation of
setDefaultOptionsinRNNSideMenuControllerdoes not callsuper. This leads to thedefaultOptionsonly being available in theRNNSideMenuPresenterbut not in the controller itself. Therefor causing bugs in accessing options that were set as defaults through the controller (as they are just not available).