Fix waitForRender + mergeOptions not working when view controller is in transit #6702
+149
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilobuerger
force-pushed
the
pendinglayouts
branch
3 times, most recently
from
97b31d3 to
5f97ef6
Compare
When running snapshot tests the completion blocks of CATransaction are never called. This way, since they are not wrapped, they will get called.
danilobuerger
force-pushed
the
pendinglayouts
branch
from
5f97ef6 to
100809d
Compare
|
@yogevbd this finally passes CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
waitForRenderis set totrue, callingNavigation.mergeOptionsearly (for example incomponentDidMount) will lead to the options not being applied as the backing view controller has not yet been placed in the window hierarchy. This PR aims to keep track of any pending view controllers and opens them up to being found via their component id. Thus enablingNavigation.mergeOptionsto work on view controllers in transit.The pending view controllers are now being kept in
RNNLayoutManager. For that reason, the layout manager was converted to be instantiable.A
NSHashTablewas chosen as the backing storage to support keeping the view controllers as a weak reference.Fixes #6085