Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix merge options on dismissModal #6719

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Fix merge options on dismissModal #6719

merged 1 commit into from
Oct 26, 2020

Conversation

yogevbd
Copy link
Collaborator

@yogevbd yogevbd commented Oct 26, 2020 •
edited by guyca
Loading

When calling dismissModal with an options object, the options were merged into the appearing modal instead of the disappearing modal.

@guyca guyca merged commit 62fc9b1 into master Oct 26, 2020
@guyca guyca deleted the fixDismissModalMergeOptions branch October 26, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyca guyca guyca approved these changes

Assignees
No one assigned
Labels
platform: iOS type: accepted/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yogevbd @guyca