Fix incorrect border radius end value #6732
Merged
+51
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently unused but should be revisited soon.
While animating ReactImageView in shared element transition, we're changing the bounds of the destination image to max(sourceImage.bounds, destinationImage.bounds) and apply a clipping rect. This apparently messes up border radius as Fresco isn't aware of the clipping rect and draws the corners according the actual image bounds. This commit splits the clip bounds animator into two animators, one for Image and another for FastImage. In the ReactImageView animator we update both clip bounds and the drawable bounds
mrousavy
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While animating ReactImageView in shared element transition, we're changing the bounds of the destination image to max(sourceImage.bounds, destinationImage.bounds) and apply a clipping Rect.
This apparently messes up border-radius as Fresco isn't aware of the clipping Rect and draws the corners according to the actual image bounds.
This commit splits the clip bounds animator into two animators, one for Image and another for FastImage.
In the ReactImageView animator, we update both clip bounds and the drawable bounds
This was noticeable when the default resize mode (cover) was used.
Note: this or doesn't add support for animating border-radius in ReactImageView. This will be added hopefully in a separate PR