Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support large bottomTab icons #6855

Merged
merged 2 commits into from
Dec 23, 2020
Merged

Support large bottomTab icons #6855

merged 2 commits into from
Dec 23, 2020

Conversation

guyca
Copy link
Collaborator

@guyca guyca commented Dec 23, 2020

This commit adds support for changing bottomTab icon dimensions on Android.
It also adds an option to disable the BottomTabs tab selection animation.

@guyca
Support large bottomTab icons
102687d 
This commit adds support for changing bottomTab icon dimensions on Android.
It also adds an option to disable the BottomTabs tab selection animation.
@yogevbd yogevbd merged commit 73c066c into master Dec 23, 2020
@yogevbd yogevbd deleted the centerTab branch December 23, 2020 11:32
@AlphaJuliettOmega
Copy link

It also adds an option to disable the BottomTabs tab selection animation.

We need this in docs
BottomTabs' options aren't documented (playground example doesn't count, can't scan X loc to find options every time I want to change a component)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogevbd yogevbd yogevbd approved these changes

Assignees

@yogevbd yogevbd

Labels
platform: Android type: accepted/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guyca @AlphaJuliettOmega @yogevbd