Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topBar button animations on iOS #7127

Merged
merged 10 commits into from
May 25, 2021
Merged

Add topBar button animations on iOS #7127

merged 10 commits into from
May 25, 2021

Conversation

yogevbd
Copy link
Collaborator

@yogevbd yogevbd commented May 20, 2021

Adds the ability to use the system's default button animations.

options: {
  topBar: {
    animateLeftButtons: true, // false by default for backward consistency
    animatedRightButtons: true // false by default for backward consistency
  }
}

@swabbass
Copy link
Contributor

Adds the ability to use the system's default button animations.

options: {
  topBar: {
    animateLeftButtons: true, // false by default for backward consistency
    animatedRightButtons: true // false by default for backward consistency
  }
}

Awesome, @yogevbd can we have a video screenshot?

@swabbass
Copy link
Contributor

swabbass commented May 24, 2021

@yogevbd, you got a typo animatedRightButtons vs animateLeftButtons , there is an easy solution for android, 3 lines of code, wdyt? cc: @guyca
Screen Shot 2021-05-24 at 6 22 20

Screen.Recording.2021-05-24.at.6.18.45.mov

@guyca
Copy link
Collaborator

guyca commented May 24, 2021

@swabbass Amazing! This is exactly what I had in mind.

@yogevbd
Copy link
Collaborator Author

yogevbd commented May 24, 2021

This is how it looks on iOS:

Screen.Recording.2021-05-24.at.12.13.27.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants