Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kotlin 1.3 & 1.4 compatibility #7144

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Fix Kotlin 1.3 & 1.4 compatibility #7144

merged 1 commit into from
Jun 1, 2021

Conversation

swabbass
Copy link
Contributor

@swabbass swabbass commented Jun 1, 2021

maxBy was deprecated for Kotlin >= 1.4.x, while maxByOrNull is not supported in 1.3.x, so, for now, it's being replaced by Kotlin independent way to find child max measured width of react component.

RNN v8 may have a minimum requirement for Kotlin as 1.4 or 1.5.

@guyca guyca merged commit f2f2412 into master Jun 1, 2021
@guyca guyca deleted the kotlin_compat branch June 1, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants