Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iOS): rename Objective-C classes with RNN prefix. #7854

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

asafkorem
Copy link
Collaborator

I've renamed our Objective-C classes to include the project's prefix (RNN) to prevent naming conflicts in the global namespace, as Objective-C lacks namespaces (e.g. DoubleRNNDouble)

The original motivation was a type conflict with Dictionary that caused a runtime crash. See: #7853

Copy link

stale bot commented Apr 22, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Apr 22, 2024
@asafkorem asafkorem marked this pull request as draft April 24, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant