fix: android onDropViewInstance not invoked when page popped #7919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NormanWangEndeavor Thank you for the quick turnaround. @mobileoss @Niryo @asafkorem I confirm, we can merge this which will resolve #7852 |
NormanWangEndeavor
force-pushed
the
fix/android-memory-leak
branch
from
8c1cae6
to
010b7f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened?
The onDropViewInstance of ViewManager is not called anymore when a screen is popped from the stack, since RN version
0.71.x.What was the expected behavior?
The onDropViewInstance of ViewManager should be called.
Was it tested on the latest react-native-navigation?
I have tested this issue on the latest react-native-navigation release and it still reproduces.
Root Cause
The
unmountReactApplicationremoves all children from RN version0.71.xwhich causes theonDropViewInstancenot to be called. Adding these removed children back resolves the problem.In what environment did this happen?
React Native Navigation version: -
React Native version: since 0.71.x
Has Fabric (React Native's new rendering system) enabled: no
Node version: -
Device model: -
Android version: -
related issue: #7852