fix: stop calling require.resolve on top level module code.

wixplosives · Sep 12, 2024 · db4de41 · db4de41
1 parent 8eda497
commit db4de41
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/packages/runtime-node/src/node-environments-manager.ts b/packages/runtime-node/src/node-environments-manager.ts
@@ -87,8 +87,6 @@ export interface RunEnvironmentOptions {
     mode?: LaunchEnvironmentMode;
 }
 
-const cliEntry = require.resolve('./remote-node-entry');
-
 export interface INodeEnvironmentsManagerOptions {
     features: Map<string, IStaticFeatureDefinition>;
     bundlePath?: string;
@@ -120,7 +118,7 @@ export interface ILaunchEnvironmentOptions {
 
 export class NodeEnvironmentsManager {
     private runningFeatures = new Map<string, { com: Communication; runningEnvironments: RunningEnvironmentRecord }>();
-
+    private cliEntry = require.resolve('./remote-node-entry');
     constructor(
         private socketServer: io.Server,
         private options: INodeEnvironmentsManagerOptions,
@@ -467,7 +465,7 @@ export class NodeEnvironmentsManager {
     }
 
     private async runRemoteNodeEnvironment(options: StartEnvironmentOptions) {
-        const { remoteNodeEnvironment, process: childProc } = await startRemoteNodeEnvironment(cliEntry, {
+        const { remoteNodeEnvironment, process: childProc } = await startRemoteNodeEnvironment(this.cliEntry, {
             inspect: this.options.inspect,
             port: this.options.port,
             socketServerOptions: this.socketServerOptions,

diff --git a/packages/runtime-node/src/worker-thread-initializer.ts b/packages/runtime-node/src/worker-thread-initializer.ts
@@ -17,13 +17,12 @@ export type WorkerThreadInitializerOptions = InitializerOptions & {
     };
 };
 
-const workerThreadEntryPath = require.resolve('./worker-thread-entry');
-
 export function workerThreadInitializer({
     communication,
     env,
     environmentStartupOptions,
 }: WorkerThreadInitializerOptions): WorkerThreadInitializer {
+    const workerThreadEntryPath = require.resolve('./worker-thread-entry');
     const disposables = createDisposables('workerThreadInitializer');
 
     const instanceId = communication.getEnvironmentInstanceId(env.env, env.endpointType);
@@ -93,6 +92,6 @@ export function workerThreadInitializer({
     return {
         id: instanceId,
         initialize,
-        dispose: ()=>disposables.dispose(),
+        dispose: () => disposables.dispose(),
     };
 }