Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(list): support multi-selection #1080

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

feat(list): support multi-selection #1080

wants to merge 20 commits into from
+497 −137

Conversation

PeterShershov
Copy link
Contributor

@PeterShershov PeterShershov commented Dec 18, 2024 •
edited
Loading

This PR adds the support for multi-selected items in the List, ScrollList and Tree components.
It includes:

  • Refactor to the selectedIds state to support a string array.
  • Refactor to the "Scroll to Focus" mechanism
  • Support multi-selection using "Ctrl/Cmd" key
  • Support range-selection for "Shift" and keyboard/mouse navigation
  • Style the tree component in some boards, extract expected styles to a constants file and add new tests.

TheAlmightyCrumb and others added 14 commits December 8, 2024 11:46
@PeterShershov PeterShershov changed the base branch from sagivd/list-multiselect to master December 18, 2024 11:18
@PeterShershov PeterShershov changed the title Peter/shift feat(list): support multi-selection Dec 18, 2024
@TheAlmightyCrumb TheAlmightyCrumb mentioned this pull request Dec 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAlmightyCrumb TheAlmightyCrumb Awaiting requested review from TheAlmightyCrumb

@alissawix alissawix Awaiting requested review from alissawix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterShershov @TheAlmightyCrumb @alissawix