The Great Tuple to Symbol Rename (tm) #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rseanhall
reviewed
Jun 28, 2020
Comment on lines
+17
to
+19
| <ProjectReference Include="..\dnchost\dnchost.vcxproj" /> | ||
| <ProjectReference Include="..\mbahost\mbahost.vcxproj" /> | ||
| <ProjectReference Include="..\wixstdba\wixstdba.vcxproj" /> |
There was a problem hiding this comment.
Instead of modifying the vcxprojs, did you try adding SkipGetTargetFrameworkProperties=true for these project references instead? I don't like that we had to add ReferenceOutputAssembly=false to the project references in the vcxprojs.
There was a problem hiding this comment.
I did not so I just tried it. Unfortunately, same error:
NU1201: Project WixToolset.Dnc.Host is not compatible with netstandard2.0 (.NETStandard,Version=v2.0). Project WixToolset.Dnc.Host supports: netcoreapp3.0 (.NETCoreApp,Version=v3.0)
It basically boils down to: dotnet/msbuild#2661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.