Fix navigating to the wrong url after joining through plex #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix going to the wrong URL after join. If you have Wizarr hosted at wizarr.example.com then after the plex signup the site will navigate to wizarr.example.com/wizarr.example.com/setup instead of wizarr.example.com/setup as it should.
bghtrbb
changed the title
|
In Flask, the best practice is to use the url_for() function to perform redirections within the app because it's more reliable and flexible. It will generate the correct URLs even if the routes in the application changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix going to the wrong URL after join. If you have Wizarr hosted at wizarr.example.com then after the plex signup the site will navigate to wizarr.example.com/wizarr.example.com/setup instead of wizarr.example.com/setup as it should if the APP_URL does not start with "http://"