Fixed Password Validation locking up Sign-up Form. #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in-secure password.
… in-secure password. Co-authored-by: Euan Miller <Moisty145@users.noreply.github.com>
|
Congrats on @Moisty145 on their first contribution. 🥳 |
|
Looks good, we try not to use try, catch, finally, but Ill at some point modify it but keep the same logic youve added, but for now I am happy to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you supply a weak password, the form will lock up and require the end user to refresh the setup process to be able to continue with set up. This PR amends this logic and allows them to edit the information they have provided.