also use LTO for library portion when NB_STATIC is specified

wjakob · Oct 27, 2022 · f64d2b9 · f64d2b9
1 parent 61393ad
commit f64d2b9
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/cmake/nanobind-config.cmake b/cmake/nanobind-config.cmake
@@ -44,7 +44,7 @@ endfunction()
 # Create shared/static library targets for nanobind's non-templated core
 # ---------------------------------------------------------------------------
 
-function (nanobuild_build_library TARGET_NAME TARGET_TYPE)
+function (nanobind_build_library TARGET_NAME TARGET_TYPE)
  if (TARGET ${TARGET_NAME})
  return()
  endif()
@@ -105,7 +105,9 @@ function (nanobuild_build_library TARGET_NAME TARGET_TYPE)
  target_compile_definitions(${TARGET_NAME} PUBLIC -DNB_SHARED)
  nanobind_strip(${TARGET_NAME})
 
- # LTO causes problems in a static build, but use it in shared release builds
+ endif()
+
+ if ((TARGET_TYPE STREQUAL "SHARED") OR (TARGET_NAME MATCHES "-lto"))
  set_target_properties(${TARGET_NAME} PROPERTIES
  INTERPROCEDURAL_OPTIMIZATION_RELEASE ON
  INTERPROCEDURAL_OPTIMIZATION_MINSIZEREL ON)
@@ -215,21 +217,26 @@ function(nanobind_add_module name)
 
  if (ARG_STABLE_ABI)
  if (ARG_NB_STATIC)
- nanobuild_build_library(nanobind-static-abi3 STATIC)
+ nanobind_build_library(nanobind-static-abi3 STATIC)
  set(libname nanobind-static-abi3)
  else()
- nanobuild_build_library(nanobind-abi3 SHARED)
+ nanobind_build_library(nanobind-abi3 SHARED)
  set(libname nanobind-abi3)
  endif()
 
  target_compile_definitions(${libname} PUBLIC -DPy_LIMITED_API=0x030C0000)
  nanobind_extension_abi3(${name})
  else()
  if (ARG_NB_STATIC)
- nanobuild_build_library(nanobind-static STATIC)
- set(libname nanobind-static)
+ if (ARG_LTO)
+ nanobind_build_library(nanobind-static-lto STATIC)
+ set(libname nanobind-static-lto)
+ else()
+ nanobind_build_library(nanobind-static STATIC)
+ set(libname nanobind-static)
+ endif()
  else()
- nanobuild_build_library(nanobind SHARED)
+ nanobind_build_library(nanobind SHARED)
  set(libname nanobind)
  endif()