This repository has been archived by the owner on Aug 11, 2023. It is now read-only.
Test coverage, type hints, and more #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor (also modified how url validation works)
…c. Refactor large portions of the app. Fix formatting and best practices throughout.
…rcase as it's not constant, and fix a bug caused by the ExcelWorkbook dataclass not using a default factory.
…ead of exiting. This allows non-failed tasks to complete and have their responses processed. Output the failed URLs and number of failed tasks
… monkeypatches to keep tests DRY. Move fixtures to subpackage-level conftest.py files.
…move redundant parse_args() function
…a json report or category other than performance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhancement: Test coverage for API keys, sitemaps, utils and cli commands - resolves Improve test coverage #2
Feature: Skip tasks that raise an exception after hitting the retry limit instead of exiting - fixes Skip the processing of a URL instead of raising SystemExit if it hits the retry limit #9
Enhancement: Warn users that custom metrics won't be configured when supplied for a json report or category other than performance - resolves Prevent conflicting commands from being used with conditional commands #3
Bug fix: Slight improvement of URL validation mechanism
Enhancement: Docstrings and type hints with mypy
Enhancement: Refactor portions of the app to be more DRY, modular and formatted more cleanly. Add a few utility functions
Bug fix: Improve sitemap error handling
Bug fix: Fix some minor edge cases revealed by type hints
Enhancement: Add a retry limit to API key re-prompt
Type of change