This repository has been archived by the owner on Aug 11, 2023. It is now read-only.
Improve exception handling, add logging and bug fixes #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… them up to main where sys.exit() is called (instead of calling SystemExit directly from within sitemaps module)
…. Allow exceptions to bubble up from keys.py to request.py to main() and call sys.exit() there instead of in modules
…it() is called for invalid URLs in cli input (instead of calling SystemExit directly in its respective module)
…ception handling for key errors and such when accessing JSON response objects
…ception is raised within a task/Coroutine - Specifically KeyringError or InvalidURLError. Fixes an issue with these types of exceptions not being raised properly.
…sts. Basically anything critical guaranteed to fail on every request. Fix a bug with URL validation (URLs with a scheme but no TLD like https://example were not invalidated before requests were made)
…ename/lineno after log message
…map format isn't chosen. Update a few log lines as well.
…tion stage to avoid hitting the keystore once per URL for sitemap reports that make multiple requests.
…house #15122 and was causing KeyErrors (how metrics are parsed will be changed soon, but this is a temporary QOL fix)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11