Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Fix reading binary columns #66

Merged
merged 1 commit into from
Jan 2, 2021
Merged

Fix reading binary columns #66

merged 1 commit into from
Jan 2, 2021

Conversation

learn-more
Copy link
Contributor

Also add a debugger check to the appx package check,
so that the application can be started from visual studio

src/MSIExtract/App.xaml.cs Outdated Show resolved Hide resolved
@wjk wjk added the bugfix Something isn't working label Jan 2, 2021
@wjk
Copy link
Owner

wjk commented Jan 2, 2021

I placed that check in OnStartup because while it might run just fine outside of the AppX package now, I might add API calls that require running inside the AppX package later. I add this check both to cover that possibility, and to remind me to always use the packaging project when I debug. I ask that you remove it from the PR, and then we'll be able to merge. Thanks!

(Also: How did you come across this bug? I've tested it on multiple MSI files, including Orca.msi, and never had any problems.)

@learn-more
Copy link
Contributor Author

I placed that check in OnStartup because while it might run just fine outside of the AppX package now, I might add API calls that require running inside the AppX package later. I add this check both to cover that possibility, and to remind me to always use the packaging project when I debug. I ask that you remove it from the PR, and then we'll be able to merge. Thanks!

(Also: How did you come across this bug? I've tested it on multiple MSI files, including Orca.msi, and never had any problems.)

Removed the other commit.
Too bad, that makes debugging somewhat more annoying, since I have to remove the packaged version.

I encountered this bug while trying to add a new feature to the tool, where you can browse all tables.

@wjk wjk merged commit f15abf7 into wjk:master Jan 2, 2021
@learn-more learn-more deleted the binary_fix branch January 2, 2021 21:05
@wjk wjk mentioned this pull request Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants