Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nested type description section #4

Merged
merged 5 commits into from
Jul 23, 2022
Merged

Add nested type description section #4

merged 5 commits into from
Jul 23, 2022

Conversation

methylDragon
Copy link
Collaborator

Ditto the title

@methylDragon
Copy link
Collaborator Author

Some things to consider (I added them in the REP also):

  • I think we should have strings for field_types to support custom type names (space-saving alternative on slack)
  • I think we should have type_name to store the name of the type (so we can use it to key the referenced_type_descriptions array)

@methylDragon methylDragon force-pushed the ch3/nested_type_descriptions branch 3 times, most recently from 8afa1cb to aed663f Compare June 15, 2022 00:55
wjwwood
wjwwood approved these changes Jul 1, 2022
View reviewed changes
@methylDragon
Add nested type description section
d6a298e 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Use Field type in message descriptions
f6eb33b 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the ch3/nested_type_descriptions branch from dfc421a to f6eb33b Compare July 8, 2022 00:49
@methylDragon
Fix unmatched parenthesis
6c1e271 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Implement nested introspection API
3039877 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the ch3/nested_type_descriptions branch from 2425fe9 to 3039877 Compare July 8, 2022 19:49
@methylDragon
Copy link
Collaborator Author

See notes in introspection API section.

It's changed a lot to support nested types, and I'm unsure if I'm making good decisions...

@methylDragon methylDragon force-pushed the ch3/nested_type_descriptions branch from 63e06ae to 423f2f9 Compare July 15, 2022 03:16
@methylDragon
Rework nested introspection API
856372d 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the ch3/nested_type_descriptions branch from 423f2f9 to 856372d Compare July 21, 2022 21:28
@wjwwood wjwwood merged commit 8dccc0f into wjwwood:evolving_message_types_rep Jul 23, 2022
@methylDragon methylDragon deleted the ch3/nested_type_descriptions branch September 8, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @wjwwood