-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Undefined on cancel, uploadProgress, downloadProgress when wrapping fetch on RN 0.44 #370
Comments
@wkh237 any thoughts on this? |
I also have this issue, even if I do const fetch = new Fetch({}).build(), the promise that comes back from fetch doesn't have uploadProgress |
I can confirm I also get the same build error. IOS uploadProgress working fine on issue-370 branch |
@jjdp , thanks for the information, I'll investigate the error and update my progress later. |
@jjdp, I've fixed the error, please try again, thanks. |
@wkh237 seems ok to me. it returns uploadProgress. both loaded and total returns bytes. formula on the wiki is not good though, it sometimes returns 0%, i made a mistake on it earlier. @timothylui can you check? |
@jjdp , thanks for the heads up. Any suggestion on the wiki's instruction ? Will be appriciate about any improvements 👍 |
@jjdp So with these changes it works fine for me on both android and ios. The only thing I've found is replacing window.fetch works fine in debug builds but does not work on release builds. If you assign it to a variable instead and use that it works fine. |
@timothylui i see, i have only tested debug build on emulator. It maybe because when you compile release on device, the environment is not on the browser anymore. Though Im not too sure about this. |
Using 0.10.8 and after |
im still on 10.6, have you tried 10.7? |
Same in 10.6, 10.7 has an error that breaks runtime. |
mine is working though, im on RN 0.45 |
Working now with 10.8, didn't know the order mattered and that it has to be before |
The object keys are there yet they are undefined when using the wrapped version. I am on RN 0.44 and rnfb 0.10.5. It is working fine though on rnfb fetch. using android simulator (does it matter)?
also how do you do formData on the rnfb fetch implementation, since I cant access the functions using the wrapper.
The text was updated successfully, but these errors were encountered: