Skip to content
This repository has been archived by the owner on Mar 16, 2019. It is now read-only.

[Polyfill] Make XMLHttpRequest compatible to whatwg-fetch #70

Closed
4 tasks done
wkh237 opened this issue Aug 2, 2016 · 3 comments
Closed
4 tasks done

[Polyfill] Make XMLHttpRequest compatible to whatwg-fetch #70

wkh237 opened this issue Aug 2, 2016 · 3 comments
Assignees
@wkh237 @puresmash
Labels
enhancement ready to merge
Milestone
v0.9.0

Comments

@wkh237
Copy link
Owner

wkh237 commented Aug 2, 2016 •
edited
Loading

Described in #69 , when replacing window.XMLHttpRequest react-native fetch becomes malfunction. Though it's still possible to use our fetch but we should still consider make XMLHttpRequest compatible to whatwg-fetch.

  • Fetch replacement
  • FileReader polyfill implementation
  • Test cases
  • Documentation
@wkh237 wkh237 added the bug label Aug 2, 2016
@wkh237 wkh237 changed the title [Polyfill] XMLHttpRequest compatible to Whatwg-fetch [Polyfill] XMLHttpRequest does not compatible to whatwg-fetch Aug 2, 2016
@wkh237 wkh237 changed the title [Polyfill] XMLHttpRequest does not compatible to whatwg-fetch [Polyfill] Make XMLHttpRequest compatible to whatwg-fetch Aug 2, 2016
@wkh237 wkh237 added enhancement and removed bug labels Aug 2, 2016
@wkh237
Copy link
Owner Author

wkh237 commented Aug 3, 2016 •
edited
Loading

It turns out if we are going to do this, we have to implement a FileReader.

W3C document

UPDATE

FileReader replacement does not work, we should implement Fetch replacement instead.

WHATWG-Fetch

wkh237 added a commit that referenced this issue Aug 3, 2016
@wkh237
Fix unicode response issue
1e1a6b0 
Fetch polyfill wip #70
wkh237 added a commit that referenced this issue Aug 3, 2016
@wkh237
code refactor #70
4d58919
wkh237 added a commit that referenced this issue Aug 4, 2016
@wkh237
Add fetch polyfill Blob reader method #70
1bbe292 
Fix Blob unicode data convertion #73
wkh237 added a commit that referenced this issue Aug 5, 2016
@wkh237
Add fetch replacement test cases #70
969daaa
wkh237 added a commit that referenced this issue Aug 5, 2016
@wkh237
Add test case #70
64ac7f2
@wkh237 wkh237 added this to the v0.9.0 milestone Aug 6, 2016
wkh237 added a commit that referenced this issue Aug 9, 2016
@wkh237
Fix Fetch.bodyUsed state #70
273f8ee
wkh237 added a commit that referenced this issue Aug 9, 2016
@wkh237
Change test case #70
0fcdf3c
@wkh237
Copy link
Owner Author

wkh237 commented Aug 10, 2016

This feature is now available in 0.9.0-beta.1

@wkh237
Copy link
Owner Author

wkh237 commented Aug 13, 2016

close on 0.9.0 release

@wkh237 wkh237 closed this as completed Aug 13, 2016
ieschalier pushed a commit to ieschalier/react-native-fetch-blob that referenced this issue Jun 26, 2018
Merge pull request wkh237#70 from milesmatthias/patch-1
d486a4f 
Add manual linking instructions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wkh237 wkh237

@puresmash puresmash

Labels
enhancement ready to merge
Projects
None yet
Milestone
v0.9.0
Development

No branches or pull requests
2 participants
@wkh237 @puresmash